From: Arne Jansen <sensille@gmx.net>
To: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, miaox@cn.fujitsu.com
Subject: Re: [PATCH 3/3] Btrfs: remove reduplicate check when disabling quota
Date: Fri, 09 Aug 2013 11:36:11 +0200 [thread overview]
Message-ID: <5204B80B.9010907@gmx.net> (raw)
In-Reply-To: <1375852351-11919-3-git-send-email-wangsl.fnst@cn.fujitsu.com>
On 07.08.2013 07:12, Wang Shilong wrote:
> We have checked 'quota_root' with qgroup_ioctl_lock held before,So
> here the check is reduplicate, remove it.
>
> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
> Reviewed-by: Miao Xie <miaox@cn.fujitsu.com>
> ---
> fs/btrfs/qgroup.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
> index b809616..df2841d 100644
> --- a/fs/btrfs/qgroup.c
> +++ b/fs/btrfs/qgroup.c
> @@ -943,11 +943,6 @@ int btrfs_quota_disable(struct btrfs_trans_handle *trans,
>
> btrfs_free_qgroup_config(fs_info);
>
> - if (!quota_root) {
> - ret = -EINVAL;
> - goto out;
> - }
> -
> ret = btrfs_clean_quota_tree(trans, quota_root);
> if (ret)
> goto out;
Reviewed-by: Arne Jansen <sensille@gmx.net>
next prev parent reply other threads:[~2013-08-09 9:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 5:12 [PATCH 1/3] Btrfs: fix oops when writing dirty qgroups to disk Wang Shilong
2013-08-07 5:12 ` [PATCH 2/3] Btrfs: move btrfs_free_qgroup_config() out of spin_lock and fix comments Wang Shilong
2013-08-09 9:42 ` Arne Jansen
2013-08-09 9:57 ` Wang Shilong
2013-08-07 5:12 ` [PATCH 3/3] Btrfs: remove reduplicate check when disabling quota Wang Shilong
2013-08-09 9:36 ` Arne Jansen [this message]
2013-08-07 5:16 ` [PATCH 1/3] Btrfs: fix oops when writing dirty qgroups to disk Wang Shilong
2013-08-08 13:20 ` Josef Bacik
2013-08-09 9:12 ` Wang Shilong
2013-08-09 9:30 ` Arne Jansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5204B80B.9010907@gmx.net \
--to=sensille@gmx.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=wangsl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.