From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Stephane Grosjean <s.grosjean@peak-system.com>
Cc: linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH] pcan_usb: fix wrong memcpy() bytes length
Date: Fri, 09 Aug 2013 11:45:31 +0200 [thread overview]
Message-ID: <5204BA3B.1060704@pengutronix.de> (raw)
In-Reply-To: <52036B60.7090701@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 924 bytes --]
On 08/08/2013 11:56 AM, Marc Kleine-Budde wrote:
> On 08/08/2013 10:52 AM, Stephane Grosjean wrote:
>> Fix possibly wrong memcpy() bytes length since some CAN records received from
>> PCAN-USB could define a DLC field in range [9..15].
>> In that case, the real DLC value MUST be used to move forward the record pointer
>> but, only 8 bytes max. MUST be copied into the data field of the struct
>> can_frame object of the skb given to the network core.
>>
>> Signed-off-by: Stephane Grosjean <s.grosjean@peak-system.com>
>
> Looks like a candidate for stable, doesn't it?
Send pull request to David with stable on Cc.
tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
prev parent reply other threads:[~2013-08-09 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 8:52 [PATCH] pcan_usb: fix wrong memcpy() bytes length Stephane Grosjean
2013-08-08 9:56 ` Marc Kleine-Budde
2013-08-08 13:45 ` Stephane Grosjean
2013-08-08 13:53 ` Marc Kleine-Budde
2013-08-09 9:45 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5204BA3B.1060704@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.