From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 5/7] Nested VMX: Check whether interrupt is blocked by TPR Date: Fri, 9 Aug 2013 11:43:53 +0100 Message-ID: <5204C7E9.3060207@citrix.com> References: <1376038175-18571-1-git-send-email-yang.z.zhang@intel.com> <1376038175-18571-6-git-send-email-yang.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1376038175-18571-6-git-send-email-yang.z.zhang@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Zhang Cc: xen-devel@lists.xensource.com, keir.xen@gmail.com, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org On 09/08/13 09:49, Yang Zhang wrote: > From: Yang Zhang > > If interrupt is blocked by L1's TPR, L2 should not see it and keep > running. Adding the check before L2 to retrive interrupt. > > Signed-off-by: Yang Zhang > --- > xen/arch/x86/hvm/vmx/intr.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c > index cb120f2..8853939 100644 > --- a/xen/arch/x86/hvm/vmx/intr.c > +++ b/xen/arch/x86/hvm/vmx/intr.c > @@ -165,6 +165,11 @@ static int nvmx_intr_intercept(struct vcpu *v, struct hvm_intack intack) > { > u32 ctrl; > > + /* If blocked by L1's tpr, then do nothing*/ As you need to respin, please have a space at the end of the sentence before */ > + if ( nestedhvm_vcpu_in_guestmode(v) && > + hvm_interrupt_blocked(v, intack) == hvm_intblk_tpr ) Alignment ~Andrew > + return 1; > + > if ( nvmx_intr_blocked(v) != hvm_intblk_none ) > { > enable_intr_window(v, intack);