From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Borkmann <dborkman@redhat.com>
Date: Fri, 09 Aug 2013 13:03:34 +0000
Subject: Re: Quick failover question
Message-Id: <5204E8A6.2050202@redhat.com>
List-Id: <linux-sctp.vger.kernel.org>
References: <CAGugRbVL1S1Am7qoz7LK4T3cqpR7-UGXkKvyRxq5AbBrz7tTWA@mail.gmail.com>
In-Reply-To: <CAGugRbVL1S1Am7qoz7LK4T3cqpR7-UGXkKvyRxq5AbBrz7tTWA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-sctp@vger.kernel.org

On 08/09/2013 02:39 PM, Karl Heiss wrote:
> Hello,
>
> I happened to be perusing the SCTP code in Linus' tree and noticed
> that the following is happening in net/sctp/associola.c,
> sctp_assoc_control_transport():
>
> /* Don't inform ULP about transition from PF to
>   * active state and set cwnd to 1, see SCTP
>   * Quick failover draft section 5.1, point 5
>   */
> if (transport->state = SCTP_PF) {
>      ulp_notify = false;
>      transport->cwnd = 1;
> }
>
>  From the quick failover draft, I see that the cwnd should be 1*MTU.
> This doesn't seem correct as other places set the cwnd as:
>
> transport->cwnd = asoc->pathmtu;
>
> Am I missing something or is this just a simplification?

I think you are correct, that doesn't seem right.

Fix is on its way.