From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Date: Fri, 09 Aug 2013 13:39:45 +0000 Subject: Re: [PATCH net] net: sctp: sctp_assoc_control_transport: fix MTU size in SCTP_PF state Message-Id: <5204F121.7080609@gmail.com> List-Id: References: <1376053748-31783-1-git-send-email-dborkman@redhat.com> In-Reply-To: <1376053748-31783-1-git-send-email-dborkman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Borkmann Cc: davem@davemloft.net, kheiss@gmail.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, Neil Horman On 08/09/2013 09:09 AM, Daniel Borkmann wrote: > The SCTP Quick failover draft [1] section 5.1, point 5 says that the cwnd > should be 1 MTU. So, instead of 1, set it to 1 MTU. > > [1] https://tools.ietf.org/html/draft-nishida-tsvwg-sctp-failover-05 > > Reported-by: Karl Heiss > Signed-off-by: Daniel Borkmann > Cc: Neil Horman > --- > net/sctp/associola.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sctp/associola.c b/net/sctp/associola.c > index bce5b79..ab67efc 100644 > --- a/net/sctp/associola.c > +++ b/net/sctp/associola.c > @@ -846,12 +846,12 @@ void sctp_assoc_control_transport(struct sctp_association *asoc, > else > spc_state = SCTP_ADDR_AVAILABLE; > /* Don't inform ULP about transition from PF to > - * active state and set cwnd to 1, see SCTP > + * active state and set cwnd to 1 MTU, see SCTP > * Quick failover draft section 5.1, point 5 > */ > if (transport->state = SCTP_PF) { > ulp_notify = false; > - transport->cwnd = 1; > + transport->cwnd = asoc->pathmtu; > } > transport->state = SCTP_ACTIVE; > break; > Acked-by: Vlad Yasevich -vlad From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: [PATCH net] net: sctp: sctp_assoc_control_transport: fix MTU size in SCTP_PF state Date: Fri, 09 Aug 2013 09:39:45 -0400 Message-ID: <5204F121.7080609@gmail.com> References: <1376053748-31783-1-git-send-email-dborkman@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, kheiss@gmail.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, Neil Horman To: Daniel Borkmann Return-path: Received: from mail-vc0-f181.google.com ([209.85.220.181]:64475 "EHLO mail-vc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966786Ab3HINjt (ORCPT ); Fri, 9 Aug 2013 09:39:49 -0400 In-Reply-To: <1376053748-31783-1-git-send-email-dborkman@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On 08/09/2013 09:09 AM, Daniel Borkmann wrote: > The SCTP Quick failover draft [1] section 5.1, point 5 says that the cwnd > should be 1 MTU. So, instead of 1, set it to 1 MTU. > > [1] https://tools.ietf.org/html/draft-nishida-tsvwg-sctp-failover-05 > > Reported-by: Karl Heiss > Signed-off-by: Daniel Borkmann > Cc: Neil Horman > --- > net/sctp/associola.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sctp/associola.c b/net/sctp/associola.c > index bce5b79..ab67efc 100644 > --- a/net/sctp/associola.c > +++ b/net/sctp/associola.c > @@ -846,12 +846,12 @@ void sctp_assoc_control_transport(struct sctp_association *asoc, > else > spc_state = SCTP_ADDR_AVAILABLE; > /* Don't inform ULP about transition from PF to > - * active state and set cwnd to 1, see SCTP > + * active state and set cwnd to 1 MTU, see SCTP > * Quick failover draft section 5.1, point 5 > */ > if (transport->state == SCTP_PF) { > ulp_notify = false; > - transport->cwnd = 1; > + transport->cwnd = asoc->pathmtu; > } > transport->state = SCTP_ACTIVE; > break; > Acked-by: Vlad Yasevich -vlad