From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gerlach Subject: Re: [PATCHv3 2/9] ARM: OMAP2+: AM33XX: control: Add some control module registers and APIs Date: Fri, 9 Aug 2013 15:55:15 -0500 Message-ID: <52055733.70808@ti.com> References: <1375811376-49985-1-git-send-email-d-gerlach@ti.com> <1375811376-49985-3-git-send-email-d-gerlach@ti.com> <5203A0BC.8060205@ti.com> <5203C457.80301@ti.com> <20130809051146.GB7656@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:60916 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031087Ab3HIUzk (ORCPT ); Fri, 9 Aug 2013 16:55:40 -0400 In-Reply-To: <20130809051146.GB7656@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: Santosh Shilimkar , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Paul Walmsley , Kevin Hilman , Vaibhav Bedia On 08/09/2013 12:11 AM, Tony Lindgren wrote: > * Dave Gerlach [130808 09:23]: >> On 08/08/2013 08:44 AM, Santosh Shilimkar wrote: >>> Lets address the above better. I don't see a need of 8 functions >>> exported doing one or 2 register writes. >>> >>> Look M3 based handling is going to be there on future SOCs >>> as well and this kind of handling of IPC is very short cited. >>> >> >> The idea here was to move all control module register accesses into >> one file in planning of implementing a driver for the control module >> itself in the future. >> >>> Probably we should have a separate driver for M3 in linux which >>> can have all this local code instead of all these exports. >> >> The wkup_m3 code has been moved to a small driver found in patch 8 >> of this series, would it better to move this code there rather than >> with the rest of the control module code? > > Please make everything you can into regular device drivers. > > We still have some dependencies to mach-omap2 code for PRCM > for example, but we're trying to get all that to live in > drivers. > > So for new pieces, let's not add further dependencies to > complicate moving things to drivers. > > Regards, > > Tony > Ok I will go ahead and pull the control module code that handles IPC into the wkup_m3 driver. The wkup_m3.c file is still present in mach-omap2 as the right location for it wasn't decided in the last RFC. Any thoughts on a good location for it? Regards, Dave From mboxrd@z Thu Jan 1 00:00:00 1970 From: d-gerlach@ti.com (Dave Gerlach) Date: Fri, 9 Aug 2013 15:55:15 -0500 Subject: [PATCHv3 2/9] ARM: OMAP2+: AM33XX: control: Add some control module registers and APIs In-Reply-To: <20130809051146.GB7656@atomide.com> References: <1375811376-49985-1-git-send-email-d-gerlach@ti.com> <1375811376-49985-3-git-send-email-d-gerlach@ti.com> <5203A0BC.8060205@ti.com> <5203C457.80301@ti.com> <20130809051146.GB7656@atomide.com> Message-ID: <52055733.70808@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/09/2013 12:11 AM, Tony Lindgren wrote: > * Dave Gerlach [130808 09:23]: >> On 08/08/2013 08:44 AM, Santosh Shilimkar wrote: >>> Lets address the above better. I don't see a need of 8 functions >>> exported doing one or 2 register writes. >>> >>> Look M3 based handling is going to be there on future SOCs >>> as well and this kind of handling of IPC is very short cited. >>> >> >> The idea here was to move all control module register accesses into >> one file in planning of implementing a driver for the control module >> itself in the future. >> >>> Probably we should have a separate driver for M3 in linux which >>> can have all this local code instead of all these exports. >> >> The wkup_m3 code has been moved to a small driver found in patch 8 >> of this series, would it better to move this code there rather than >> with the rest of the control module code? > > Please make everything you can into regular device drivers. > > We still have some dependencies to mach-omap2 code for PRCM > for example, but we're trying to get all that to live in > drivers. > > So for new pieces, let's not add further dependencies to > complicate moving things to drivers. > > Regards, > > Tony > Ok I will go ahead and pull the control module code that handles IPC into the wkup_m3 driver. The wkup_m3.c file is still present in mach-omap2 as the right location for it wasn't decided in the last RFC. Any thoughts on a good location for it? Regards, Dave