Re: [PATCH v3 3/3] libata: Add support for queued DSM TRIM

[Marc C <marc.ceeeee@gmail.com>]

Hello,

On 8/9/2013 7:08 AM, Tejun Heo wrote:

> So, there are controllers which actually look at the command code and
> thus will choke on new commands and just looking at whether the device
> supports the new commands is likely to be insufficient.  Have you
> tested this?  If so, on which controllers / devices?  We're likely to
> need whitelisting on controller side, I think.
Not entirely sure. Non-AHCI controllers scare me since they typically
don't come along with specs, or are just finicky. This is especially
true since this is a new NCQ command. Anyway, I'll use a flag (as
suggested in the other thread) to differentiate between controllers that
_should_ be able to handle this properly (AHCI) and other
vendor-specific SATA controllers.

Thanks,
Marc