All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Maksim A. Boyko" <maksboyko@yandex.ru>
Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org,
	stable@vger.kernel.org, maksim.a.boyko@gmail.com
Subject: Re: [PATCH] usb-audio: Fix invalid volume resolution for Logitech HD Webcam C525
Date: Sat, 10 Aug 2013 22:39:52 +0400	[thread overview]
Message-ID: <520688F8.7090808@cogentembedded.com> (raw)
In-Reply-To: <5205F7B2.7030505@yandex.ru>

Hello.

On 08/10/2013 12:20 PM, Maksim A. Boyko wrote:

> Add the volume control quirk for avoiding the kernel warning
> for the Logitech HD Webcam C525
> as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2

    Please also specify that commit's summary line in parens.

> for the Logitech HD Webcam C310.

> Reported-by: Maksim Boyko <maksim.a.boyko@gmail.com>
> Tested-by: Maksim Boyko <maksim.a.boyko@gmail.com>
> Cc: <stable@vger.kernel.org> # 3.10.5+
> Signed-off-by: Maksim Boyko <maksim.a.boyko@gmail.com>
> --
>   sound/usb/mixer.c |    1 +
>   1 file changed, 1 insertion(+)
>
> --- linux-3.10.5-orig/sound/usb/mixer.c    2013-08-04 12:51:49.000000000
> +0400
> +++ linux-3.10.5/sound/usb/mixer.c    2013-08-06 21:12:42.274197287
> +0400
> @@ -888,6 +888,7 @@ static void volume_control_quirks(struct
>       case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
>       case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
>       case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
> +    case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
>       case USB_ID(0x046d, 0x0991):
>       /* Most audio usb devices lie about volume resolution.
>        * Most Logitech webcams have res = 384.
>
>
> --
> WBR, Maksim

> P.S. Please, use this patch due to it should have correct tab symbols.

    Unfortunately, it seems to have a space added before each line starting 
with space.

WBR, Sergei

  reply	other threads:[~2013-08-10 18:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09  8:37 [PATCH] usb-audio: Fix invalid volume resolution for Logitech HD Webcam C525 Maxim Boyko
2013-08-10  8:20 ` Maksim A. Boyko
2013-08-10 18:39   ` Sergei Shtylyov [this message]
     [not found]   ` <5205F7B2.7030505-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org>
2013-08-12 12:55     ` [alsa-devel] " Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2013-08-11  8:39 Maksim A. Boyko
     [not found] ` <52074DBB.7040504-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org>
2013-08-11 17:23   ` Sergei Shtylyov
2013-08-09  8:28 Maxim Boyko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520688F8.7090808@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=maksboyko@yandex.ru \
    --cc=maksim.a.boyko@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.