From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8WtQ-00088s-2J for qemu-devel@nongnu.org; Sun, 11 Aug 2013 10:45:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8WtK-0000O9-G5 for qemu-devel@nongnu.org; Sun, 11 Aug 2013 10:45:16 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59774 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8WtK-0000O0-6x for qemu-devel@nongnu.org; Sun, 11 Aug 2013 10:45:10 -0400 Message-ID: <5207A36F.2050308@suse.de> Date: Sun, 11 Aug 2013 16:45:03 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1375362537.4891.28.camel@localhost.localdomain> <1375427079-16822-1-git-send-email-hutao@cn.fujitsu.com> <51FB6D73.9090902@redhat.com> <20130811103341.GA13848@redhat.com> In-Reply-To: <20130811103341.GA13848@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.6 1/2] don't create pvpanic device by default. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Paolo Bonzini , qemu-devel@nongnu.org, Hu Tao Am 11.08.2013 12:33, schrieb Michael S. Tsirkin: > On Fri, Aug 02, 2013 at 10:27:31AM +0200, Paolo Bonzini wrote: >> On 08/02/2013 09:04 AM, Hu Tao wrote: >>> The problem with pvpanic being an internal device is that VMs running >>> operating systems without a driver for this device will have problems >>> when qemu will be upgraded (from qemu without this pvpanic). >>> >>> The outcome may be, for example: in Windows(let's say XP) the Device >>> manager will open a "new device" wizard and the device will appear as >>> an unrecognized device. On a cluster with hundreds of such VMs, If >>> that cluster has a health monitoring service it may show all the VMs >>> in a "not healthy" state. >>> >>> Reported-by: Marcel Apfelbaum >>> Signed-off-by: Hu Tao >> >> NACK, >> >> this is premature. It is fundamentally a firmware problem. >> >> We have time to apply an even smaller patch that doesn't set >> has_pvpanic to true, and delay the whole feature to 1.7, if we do >> not fix the firmware in the next two weeks. >> >> Paolo >=20 > I think this is not just a firmware problem. Adding device by default > was too rush, assumption was risk of guest bugs was 0. >=20 > We are now seeing problems with bios guest code and with linux guest > drivers as well. Yes they all can be fixed, but we simply shouldn't > force this risk of broken guests on everyone. >=20 > libvirt is the main user and libvirt people > indicated their preference to creating device with > -device pvpanic rather than a built-in one that > can't be removed. >=20 > So please reconsider, and here's an ack from me. >=20 > Acked-by: Michael S. Tsirkin NACK for this v1: As pointed out on the KVM call, we still need to keep the pvpanic device around by default for pc-*-1.5. Removing has_pvpanic completely therefore seems wrong. Can you submit a v2 for rc3 tomorrow? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg