From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ying Xue Subject: Re: [PATCH v2] tipc: avoid possible deadlock while enable and disable bearer Date: Mon, 12 Aug 2013 13:03:46 +0800 Message-ID: <52086CB2.3050006@windriver.com> References: <5204B29A.80809@huawei.com> <5204B78D.4090509@windriver.com> <20130811.215939.1897644088555839854.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: , , , , , To: David Miller Return-path: Received: from mail7.windriver.com ([128.224.252.3]:45513 "EHLO mail7.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753171Ab3HLFEL (ORCPT ); Mon, 12 Aug 2013 01:04:11 -0400 In-Reply-To: <20130811.215939.1897644088555839854.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On 08/12/2013 12:59 PM, David Miller wrote: > From: Ying Xue > Date: Fri, 9 Aug 2013 17:34:05 +0800 > >> >>> The problem is that the tipc_link_delete() will cancel the timer disc_timeout() when >>> the b_ptr->lock is hold, but the disc_timeout() still call b_ptr->lock to finish the >>> work, so the dead lock occurs. >>> >>> We should unlock the b_ptr->lock when del the disc_timeout(). >>> >>> Remove link_timeout() still met the same problem, the patch: >>> >>> http://article.gmane.org/gmane.network.tipc.general/4380 >>> >>> fix the problem, so no need to send patch for fix link_timeout() deadlock warming. >>> >>> Signed-off-by: Wang Weidong >>> Signed-off-by: Ding Tianhong >>> Cc: Ying Xue >> >> Ack-by: Ying Xue > > The proper syntax is "Acked-by: " not "Ack-by: " > Thanks, I knew :) Regards, Ying > Applied. > >