All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2 of 6 v2] linux: don't take HEAD as default for git repositories
Date: Mon, 12 Aug 2013 08:02:41 +0200	[thread overview]
Message-ID: <52087A81.4050404@mind.be> (raw)
In-Reply-To: <6d0a6d80647910c487ba.1374650579@BEANTN0L019720>

On 24/07/13 09:22, Thomas De Schampheleire wrote:
> Specifying a floating tag like HEAD for a repository version is bad practice,
> as it results in non-reproducible builds. This patch removes the default
> assignment of HEAD as version when a custom git repository is used for the
> Linux kernel.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

  I would still push this one in 2013.08.

  Regards,
  Arnout

>
> ---
> (v2): new patch in series after comment from Peter
>
>   linux/Config.in |  1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/linux/Config.in b/linux/Config.in
> --- a/linux/Config.in
> +++ b/linux/Config.in
> @@ -68,7 +68,6 @@ config BR2_LINUX_KERNEL_CUSTOM_GIT_REPO_
>
>   config BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION
>   	string "Custom Git version"
> -	default "HEAD"
>   	depends on BR2_LINUX_KERNEL_CUSTOM_GIT
>   	help
>   	  Git revision to use in the format used by git rev-parse,
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2013-08-12  6:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-24  7:22 [Buildroot] [PATCH 0 of 6 v2] linux/uboot: add support for custom Mercurial repositories Thomas De Schampheleire
2013-07-24  7:22 ` [Buildroot] [PATCH 1 of 6 v2] Config.in.legacy: update description Thomas De Schampheleire
2013-07-27 13:50   ` Thomas Petazzoni
2013-08-12  5:59   ` Arnout Vandecappelle
2013-08-13 16:31   ` Arnout Vandecappelle
2013-08-14 16:27     ` Thomas De Schampheleire
2013-07-24  7:22 ` [Buildroot] [PATCH 2 of 6 v2] linux: don't take HEAD as default for git repositories Thomas De Schampheleire
2013-08-12  6:02   ` Arnout Vandecappelle [this message]
2013-08-13 10:00   ` Thomas Petazzoni
2013-07-24  7:23 ` [Buildroot] [PATCH 3 of 6 v2] linux: add support for custom Mercurial repository Thomas De Schampheleire
2013-08-12  6:12   ` Arnout Vandecappelle
2013-08-12 10:54     ` Thomas De Schampheleire
2013-08-12 11:01       ` Arnout Vandecappelle
2013-08-13  9:09     ` Thomas Petazzoni
2013-08-13 16:30       ` Arnout Vandecappelle
2013-08-14 17:06         ` Thomas De Schampheleire
2013-08-17  8:13           ` Thomas De Schampheleire
2013-08-19 16:05             ` Arnout Vandecappelle
2013-08-20  8:36               ` Thomas De Schampheleire
2013-08-21  5:40                 ` Arnout Vandecappelle
2013-08-27 12:29                   ` Thomas De Schampheleire
2013-08-27 14:14                   ` Thomas De Schampheleire
2013-07-24  7:23 ` [Buildroot] [PATCH 4 of 6 v2] u-boot: " Thomas De Schampheleire
2013-07-24  7:23 ` [Buildroot] [PATCH 5 of 6 v2] linux/uboot: line-up repository-related configuration options Thomas De Schampheleire
2013-07-24  7:23 ` [Buildroot] [PATCH 6 of 6 v2] linux: mention 3.x.y kernels in 'custom version' help Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52087A81.4050404@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.