All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH] env: add default env size for CONFIG_ENV_IS_NOWHERE
Date: Mon, 12 Aug 2013 21:07:16 +0800	[thread overview]
Message-ID: <5208DE04.1000405@gmail.com> (raw)
In-Reply-To: <20130811145016.677F7380E10@gemini.denx.de>

Hi Wolfgang Denk,

On 8/11/2013 10:50 PM, Wolfgang Denk wrote:
> Dear Bo Shen,
>
> In message <1376230503-25331-1-git-send-email-voice.shen@gmail.com> you wrote:
>> when CONFIG_ENV_IS_NOWHERE is enabled, it is still need to define
>> CONFIG_ENV_SIZE. So, add a default size (1024 Bytes) to avoid
>> compile error if not define CONFIG_ENV_SIZE
>
> I don;t understand the rationale for this patch.  In which way is the
> environment seize for the CONFIG_ENV_IS_NOWHERE case different from
> any other cases?  For these, we do not define a default either, so why
> should we handle this case differently?

In my opinion, there is a little different. The CONFIG_ENV_IS_NOWHERE 
case only store environment in volatile memory (e.g. DDR SDRAM) while 
not store in non-volatile device.

At first glance of CONFIG_ENV_IS_NOWHERE, I think no need to define the 
CONFIG_ENV_SIZE, actually, it needs to define the CONFIG_ENV_SIZE. So, I 
think add a default value will be better (Maybe another choice to add a 
description in README file to specify how to use CONFIG_ENV_IS_NOWHERE).

> In any cse, the needed environment seize if a pretty board specific
> thing, and I think it makes sense to let the user define it.

Yes, the environment size is a pretty board specific thing. So, in this 
patch, there is an option for user to define it.

> Best regards,
>
> Wolfgang Denk
>

Best Regards,
Bo Shen

  reply	other threads:[~2013-08-12 13:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-11 14:15 [U-Boot] [RFC PATCH] env: add default env size for CONFIG_ENV_IS_NOWHERE Bo Shen
2013-08-11 14:50 ` Wolfgang Denk
2013-08-12 13:07   ` Bo Shen [this message]
2013-08-12 13:29     ` Wolfgang Denk
2013-08-12 13:39 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5208DE04.1000405@gmail.com \
    --to=voice.shen@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.