All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tang Chen <imtangchen@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Joe Perches <joe@perches.com>,
	Tang Chen <tangchen@cn.fujitsu.com>,
	robert.moore@intel.com, lv.zheng@intel.com, rjw@sisk.pl,
	lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu,
	hpa@zytor.com, akpm@linux-foundation.org, trenn@suse.de,
	yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com,
	laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
	izumi.taku@jp.fujitsu.com, mgorman@suse.de, minchan@kernel.org,
	mina86@mina86.com, gong.chen@linux.intel.com,
	vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com,
	riel@redhat.com, jweiner@redhat.com, prarit@redhat.com,
	zhangyanfei@cn.fujitsu.com, yanghy@cn.fujitsu.com,
	x86@kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH part2 3/4] acpi: Remove "continue" in macro INVALID_TABLE().
Date: Mon, 12 Aug 2013 22:25:48 +0800	[thread overview]
Message-ID: <5208F06C.8090206@gmail.com> (raw)
In-Reply-To: <20130812142119.GF15892@htj.dyndns.org>

On 08/12/2013 10:21 PM, Tejun Heo wrote:
> On Thu, Aug 08, 2013 at 07:09:53AM -0700, Joe Perches wrote:
>> If you really think that the #define is better, use
>> something like HW_ERR does and embed that #define
>> in the pr_err.
>>
>> #define ACPI_OVERRIDE	"ACPI OVERRIDE: "
>>
>> 	pr_err(ACPI_OVERRIDE "Table smaller than ACPI header [%s%s]\n",
>> 	       cpio_path, file.name);
>>
>> It's only used a few times by a single file so
>> I think it's unnecessary.
>
> I agree with Joe here.  Just doing normal pr_err() should be enough.
> You can use pr_fmt() to add headers but given that we aren't talking
> about huge number of printks, that probably is an overkill too.

OK, followed.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Tang Chen <imtangchen@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Joe Perches <joe@perches.com>,
	Tang Chen <tangchen@cn.fujitsu.com>,
	robert.moore@intel.com, lv.zheng@intel.com, rjw@sisk.pl,
	lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu,
	hpa@zytor.com, akpm@linux-foundation.org, trenn@suse.de,
	yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com,
	laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
	izumi.taku@jp.fujitsu.com, mgorman@suse.de, minchan@kernel.org,
	mina86@mina86.com, gong.chen@linux.intel.com,
	vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com,
	riel@redhat.com, jweiner@redhat.com, prarit@redhat.com,
	zhangyanfei@cn.fujitsu.com, yanghy@cn.fujitsu.com,
	x86@kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH part2 3/4] acpi: Remove "continue" in macro INVALID_TABLE().
Date: Mon, 12 Aug 2013 22:25:48 +0800	[thread overview]
Message-ID: <5208F06C.8090206@gmail.com> (raw)
In-Reply-To: <20130812142119.GF15892@htj.dyndns.org>

On 08/12/2013 10:21 PM, Tejun Heo wrote:
> On Thu, Aug 08, 2013 at 07:09:53AM -0700, Joe Perches wrote:
>> If you really think that the #define is better, use
>> something like HW_ERR does and embed that #define
>> in the pr_err.
>>
>> #define ACPI_OVERRIDE	"ACPI OVERRIDE: "
>>
>> 	pr_err(ACPI_OVERRIDE "Table smaller than ACPI header [%s%s]\n",
>> 	       cpio_path, file.name);
>>
>> It's only used a few times by a single file so
>> I think it's unnecessary.
>
> I agree with Joe here.  Just doing normal pr_err() should be enough.
> You can use pr_fmt() to add headers but given that we aren't talking
> about huge number of printks, that probably is an overkill too.

OK, followed.

Thanks.


  reply	other threads:[~2013-08-12 14:25 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08  5:03 [PATCH part2 0/4] acpi: Trivial fix and improving for memory hotplug Tang Chen
2013-08-08  5:03 ` Tang Chen
2013-08-08  5:03 ` [PATCH part2 1/4] acpi: Print Hot-Pluggable Field in SRAT Tang Chen
2013-08-08  5:03   ` Tang Chen
2013-08-12 14:15   ` Tejun Heo
2013-08-12 14:15     ` Tejun Heo
2013-08-12 14:25     ` Tang Chen
2013-08-12 14:25       ` Tang Chen
2013-08-08  5:03 ` [PATCH part2 2/4] earlycpio.c: Fix the confusing comment of find_cpio_data() Tang Chen
2013-08-08  5:03   ` Tang Chen
2013-08-12 14:17   ` Tejun Heo
2013-08-12 14:17     ` Tejun Heo
2013-08-08  5:03 ` [PATCH part2 3/4] acpi: Remove "continue" in macro INVALID_TABLE() Tang Chen
2013-08-08  5:03   ` Tang Chen
2013-08-08  5:27   ` Joe Perches
2013-08-08  5:27     ` Joe Perches
2013-08-08 12:18     ` Tang Chen
2013-08-08 12:18       ` Tang Chen
2013-08-08 14:09       ` Joe Perches
2013-08-08 14:09         ` Joe Perches
2013-08-12 14:21         ` Tejun Heo
2013-08-12 14:21           ` Tejun Heo
2013-08-12 14:25           ` Tang Chen [this message]
2013-08-12 14:25             ` Tang Chen
2013-08-08  5:03 ` [PATCH part2 4/4] acpi: Introduce acpi_verify_initrd() to check if a table is invalid Tang Chen
2013-08-08  5:03   ` Tang Chen
2013-08-08 14:09 ` [PATCH part2 0/4] acpi: Trivial fix and improving for memory hotplug Rafael J. Wysocki
2013-08-08 14:09   ` Rafael J. Wysocki
2013-08-09  0:37   ` Tang Chen
2013-08-09  0:37     ` Tang Chen
2013-08-09 13:36     ` Rafael J. Wysocki
2013-08-09 13:36       ` Rafael J. Wysocki
2013-08-09 15:59       ` Tejun Heo
2013-08-09 15:59         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5208F06C.8090206@gmail.com \
    --to=imtangchen@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=gong.chen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=jiang.liu@huawei.com \
    --cc=joe@perches.com \
    --cc=jweiner@redhat.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lv.zheng@intel.com \
    --cc=lwoodman@redhat.com \
    --cc=mgorman@suse.de \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    --cc=mingo@elte.hu \
    --cc=prarit@redhat.com \
    --cc=riel@redhat.com \
    --cc=rjw@sisk.pl \
    --cc=robert.moore@intel.com \
    --cc=tangchen@cn.fujitsu.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=trenn@suse.de \
    --cc=vasilis.liaskovitis@profitbricks.com \
    --cc=wency@cn.fujitsu.com \
    --cc=x86@kernel.org \
    --cc=yanghy@cn.fujitsu.com \
    --cc=yinghai@kernel.org \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.