From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 35/35] cpufreq: tegra: use cpufreq_table_validate_and_show() Date: Mon, 12 Aug 2013 10:33:43 -0600 Message-ID: <52090E67.1080703@wwwdotorg.org> References: <568f3dbd414b050bb2319d960fb5044a5aed8ee3.1375964117.git.viresh.kumar@linaro.org> <5203BCDD.40809@wwwdotorg.org> <5205167F.1070906@wwwdotorg.org> <52056842.8060109@wwwdotorg.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: cpufreq-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, Stephen Warren , linux-pm@vger.kernel.org, patches@linaro.org, linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org, rjw@sisk.pl, linux-arm-kernel@lists.infradead.org On 08/09/2013 08:53 PM, Viresh Kumar wrote: > On 10 August 2013 03:38, Stephen Warren wrote: >> Well, I don't see any issues running this, although the cpufreq sysfs >> files seem to have disappeared on Tegra, even without your changes, so >> I'm not sure how to really verify cpufreq. >> >> Did the sysfs files go away, or do I need to investigate why/when the >> disappeared? > > It wasn't enabled by default in your defconfig... So enable it first with > your menuconfig. It's in defconfig OK; I think the driver simply isn't initializing since some of the clocks it requests don't exist. I'll have our clock driver author look into it. In the meantime, I assume that your change is likely fine. From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Mon, 12 Aug 2013 10:33:43 -0600 Subject: [PATCH 35/35] cpufreq: tegra: use cpufreq_table_validate_and_show() In-Reply-To: References: <568f3dbd414b050bb2319d960fb5044a5aed8ee3.1375964117.git.viresh.kumar@linaro.org> <5203BCDD.40809@wwwdotorg.org> <5205167F.1070906@wwwdotorg.org> <52056842.8060109@wwwdotorg.org> Message-ID: <52090E67.1080703@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/09/2013 08:53 PM, Viresh Kumar wrote: > On 10 August 2013 03:38, Stephen Warren wrote: >> Well, I don't see any issues running this, although the cpufreq sysfs >> files seem to have disappeared on Tegra, even without your changes, so >> I'm not sure how to really verify cpufreq. >> >> Did the sysfs files go away, or do I need to investigate why/when the >> disappeared? > > It wasn't enabled by default in your defconfig... So enable it first with > your menuconfig. It's in defconfig OK; I think the driver simply isn't initializing since some of the clocks it requests don't exist. I'll have our clock driver author look into it. In the meantime, I assume that your change is likely fine.