From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51690)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1V8v7F-0008VP-NJ
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:37:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1V8v78-0008Dv-9i
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:37:09 -0400
Received: from goliath.siemens.de ([192.35.17.28]:22751)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1V8v78-0008D9-0w
	for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:37:02 -0400
Message-ID: <52090F1F.9060503@siemens.com>
Date: Mon, 12 Aug 2013 18:36:47 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1376239405-4084-1-git-send-email-alex@alex.org.uk>
	<1376239405-4084-9-git-send-email-alex@alex.org.uk>
	<520909D0.3040203@siemens.com>
	<EE9C4CF0-CBEA-43F0-9155-5B2731721C38@alex.org.uk>
In-Reply-To: <EE9C4CF0-CBEA-43F0-9155-5B2731721C38@alex.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] [PATCHv10 08/31] aio / timers: Split
 QEMUClock into QEMUClock and QEMUTimerList
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, liu ping fan <qemulist@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

On 2013-08-12 18:25, Alex Bligh wrote:
> 
> On 12 Aug 2013, at 17:14, Jan Kiszka wrote:
> 
>> The typedef part is a duplication of what we already have in
>> qemu/typedefs.h and breaks the build for me. Just declare the struct here.
> 
> You mean one can't do
> 
> typedef struct foo foo;
> ...
> typedef struct foo {
>   ...
> } foo;
> 
> ?

Yes, at least according to the standard. Older gcc seem to reject it,
newer may have relaxed this by default.

> 
> I don't even get a warning for that. Learn a new thing every
> day. OK will fix. I guess that means timer.h needs to explicitly
> include typedefs.h in case whatever is including timer.h does
> not first include typedefs.h.

It works without explicit including as most users pull in qemu-common.h
as well, but it's cleaner of course.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux