From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8vAK-00028B-DL for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:40:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8vAB-0001i3-NR for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:40:20 -0400 Received: from david.siemens.de ([192.35.17.14]:26328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8vAB-0001gx-EE for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:40:11 -0400 Message-ID: <52090FE1.4040800@siemens.com> Date: Mon, 12 Aug 2013 18:40:01 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1376239405-4084-1-git-send-email-alex@alex.org.uk> <1376239405-4084-10-git-send-email-alex@alex.org.uk> In-Reply-To: <1376239405-4084-10-git-send-email-alex@alex.org.uk> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] [PATCHv10 09/31] aio / timers: Untangle include files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: Kevin Wolf , Anthony Liguori , qemu-devel@nongnu.org, liu ping fan , Stefan Hajnoczi , Paolo Bonzini , MORITA Kazutaka , rth@twiddle.net On 2013-08-11 18:43, Alex Bligh wrote: > include/qemu/timer.h has no need to include main-loop.h and > doing so causes an issue for the next patch. Unfortunately > various files assume including timers.h will pull in main-loop.h. > Untangle this mess. > Hmm, this triggers a double typedef of AioContext for me. I've resolved it like the QEMUTimer issue: moved the typedef to typedefs.h. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux