Re: [Qemu-devel] [QEMU-1.6 PATCH] vl.c: Output error on invalid machine type provided

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

On 08/12/2013 10:28 AM, Michal Novotny wrote:
> Output error message using qemu's error_report() function when user
> provides the invalid machine type on the command line. This also saves
> time to find what issue is when you downgrade from one version of qemu
> to another that doesn't support required machine type yet (the version
> user downgraded to have to have this patch applied too, of course).

s/have to have/has to have/

> 
> Signed-off-by: Michal Novotny <minovotn@redhat.com>
> ---
>  vl.c | 5 +++++
>  1 file changed, 5 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

(It helps to add a v6 or repost nomenclature in the subject line, when
pointing out that this is a repost of a v5 [1]; also, when the patch is
unchanged from an already-reviewed earlier version, it is recommended
that you amend the message to include Reviewed-by lines carried forward,
rather than waiting for reviewers to repeat their comments [2])

[1] https://lists.gnu.org/archive/html/qemu-devel/2013-08/msg01589.html
[2] http://wiki.qemu.org/Contribute/SubmitAPatch

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]