From: Saul Wold <sgw@linux.intel.com>
To: Ross Burton <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] cogl: GL/GLX feature cleanup
Date: Mon, 12 Aug 2013 10:52:26 -0700 [thread overview]
Message-ID: <520920DA.7020506@linux.intel.com> (raw)
In-Reply-To: <1376316560-10880-1-git-send-email-ross.burton@intel.com>
On 08/12/2013 07:09 AM, Ross Burton wrote:
> Separate GL and GLX flags don't make sense, as on Linux GL means GLX and GLX
> means GL.
>
> So, default to GLESv2 and GLX if X11 is enabled. EGL on X11 doesn't have
> feature parity yet so leave it disabled by default.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-graphics/cogl/cogl-1.0.inc | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/meta/recipes-graphics/cogl/cogl-1.0.inc b/meta/recipes-graphics/cogl/cogl-1.0.inc
> index c0d410e..c189e95 100644
> --- a/meta/recipes-graphics/cogl/cogl-1.0.inc
> +++ b/meta/recipes-graphics/cogl/cogl-1.0.inc
> @@ -28,16 +28,17 @@ EDEPENDS_WAYLAND = "wayland"
> ERDEPENDS_GL = "libgl"
> ERDEPENDS_GLES2 = "libgles2"
>
> ++# GLESv1 is rarely tested, so disable it
Seems to be a patch issue here with the ++
Sau!
> EXTRA_OECONF += "--disable-introspection \
> --enable-examples-install \
> --enable-debug \
> --disable-gles1 \
> "
>
> -PACKAGECONFIG[cogl-pango] = "--enable-cogl-pango,--disable-cogl-pango,pango"
> +# OpenGL/GLX
> +PACKAGECONFIG[glx] = "--enable-gl --enable-glx,--disable-gl --disable-glx,${EDEPENDS_GL} ${EDEPENDS_X11},${ERDEPENDS_GL}"
>
> -# GL flavours
> -PACKAGECONFIG[gl] = "--enable-gl,--disable-gl,${EDEPENDS_GL},${ERDEPENDS_GL}"
> +# GLESv2
> PACKAGECONFIG[gles2] = "--enable-gles2,--disable-gles2,${EDEPENDS_GLES2}, ${ERDEPENDS_GLES2}"
>
> # EGL backends
> @@ -46,15 +47,15 @@ PACKAGECONFIG[egl-null] = "--enable-null-egl-platform,--disable-null-egl-platfor
> PACKAGECONFIG[egl-x11] = "--enable-xlib-egl-platform,--disable-xlib-egl-platform,${EDEPENDS_X11}"
> PACKAGECONFIG[egl-wayland] = "--enable-wayland-egl-platform,--disable-wayland-egl-platform,${EDEPENDS_WAYLAND}"
>
> -# GLX
> -PACKAGECONFIG[glx] = "--enable-glx,--disable-glx,${EDEPENDS_GL} ${EDEPENDS_X11}"
> -
> -# Wayland server-side
> +# Wayland (server-side)
> PACKAGECONFIG[wayland-server] = "--enable-wayland-egl-server,--disable-wayland-egl-server,${EDEPENDS_WAYLAND}"
>
> +# Support rendering text directly with Pango
> +PACKAGECONFIG[cogl-pango] = "--enable-cogl-pango,--disable-cogl-pango,pango"
> +
> # Respect the DISTRO_FEATURES to pull in GLX or Wayland as appropriate by
> # default.
> -PACKAGECONFIG ??= "cogl-pango gl \
> +PACKAGECONFIG ??= "cogl-pango gles2 \
> ${@base_contains('DISTRO_FEATURES', 'wayland', 'egl-wayland', '', d)} \
> ${@base_contains('DISTRO_FEATURES', 'x11', 'glx', '', d)}"
>
>
prev parent reply other threads:[~2013-08-12 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 14:09 [PATCH] cogl: GL/GLX feature cleanup Ross Burton
2013-08-12 17:52 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520920DA.7020506@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.