From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v3] arm: omap5: dts: add palmas-usb node Date: Mon, 12 Aug 2013 17:09:54 -0600 Message-ID: <52096B42.60500@wwwdotorg.org> References: <1373979037-27587-1-git-send-email-balbi@ti.com> <1376302675-15795-1-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1376302675-15795-1-git-send-email-kishon@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Kishon Vijay Abraham I Cc: benoit.cousson@linaro.org, tony@atomide.com, rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, ian.campbell@citrix.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, balbi@ti.com List-Id: linux-omap@vger.kernel.org On 08/12/2013 04:17 AM, Kishon Vijay Abraham I wrote: > From: Felipe Balbi > > Without this node, there will be no palmas > driver to notify dwc3 that a cable has > been connected and, without that, dwc3 > will never initialize. > diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts > interrupt-controller; > #interrupt-cells = <2>; > > + extcon_usb3: palmas_usb { > + compatible = "ti,palmas-usb"; This isn't so much a comment on this patch as the Palmas binding: Presumably, the Palmas device contains a USB VID detector, not a whole USB controller. I'd expect the compatible value to indicate this more directly, i.e. be something like ti,palmas-usb-vid or ti,palmas-usb-vid-detector. From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Mon, 12 Aug 2013 17:09:54 -0600 Subject: [PATCH v3] arm: omap5: dts: add palmas-usb node In-Reply-To: <1376302675-15795-1-git-send-email-kishon@ti.com> References: <1373979037-27587-1-git-send-email-balbi@ti.com> <1376302675-15795-1-git-send-email-kishon@ti.com> Message-ID: <52096B42.60500@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/12/2013 04:17 AM, Kishon Vijay Abraham I wrote: > From: Felipe Balbi > > Without this node, there will be no palmas > driver to notify dwc3 that a cable has > been connected and, without that, dwc3 > will never initialize. > diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts > interrupt-controller; > #interrupt-cells = <2>; > > + extcon_usb3: palmas_usb { > + compatible = "ti,palmas-usb"; This isn't so much a comment on this patch as the Palmas binding: Presumably, the Palmas device contains a USB VID detector, not a whole USB controller. I'd expect the compatible value to indicate this more directly, i.e. be something like ti,palmas-usb-vid or ti,palmas-usb-vid-detector.