All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: "Gupta, Pekon" <pekon@ti.com>
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"dedekind1@gmail.com" <dedekind1@gmail.com>
Subject: Re: [PATCH 01/10] mtd: set the cell information for ONFI nand
Date: Tue, 13 Aug 2013 14:19:41 +0800	[thread overview]
Message-ID: <5209CFFD.8000501@freescale.com> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73E9F4137@DBDE04.ent.ti.com>

于 2013年08月13日 12:10, Gupta, Pekon 写道:
>> On Tue, Aug 13, 2013 at 11:03:14AM +0800, Huang Shijie wrote:
>>> 于 2013年08月13日 08:49, Brian Norris 写道:
>>>       currently), we should modify it so that is a reliable source of
>>>       *only* 1
>>>       piece of information -- the number of bits per cell. Currently, it
>>> do you need to rename the cellinfo to bits_per_cell, or add a new field :
>>> bits_per_cell?
>> Well, my whole point was that 'cellinfo' is really not very useful for
>> us. We just mask it off all the time, and it makes life more
>> complicated.
>>
>> So I'd just rename cellinfo to bits_per_cell and change its
>> assignment/usage appropriately.
>>
> [Pekon]: How about moving 'bit_per_cell' info to chip->options ?
sorry, i do not think this is a good idea.

the drivers may changes the chip->options.

I prefer to keep it as new field.

thanks
Huang Shijie

  reply	other threads:[~2013-08-13  6:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12  5:42 [PATCH 00/10] About the SLC/MLC Huang Shijie
2013-08-12  5:42 ` [PATCH 01/10] mtd: set the cell information for ONFI nand Huang Shijie
2013-08-12  7:22   ` Gupta, Pekon
2013-08-12  7:27     ` Huang Shijie
2013-08-13  0:49     ` Brian Norris
2013-08-13  2:32       ` Huang Shijie
2013-08-13  2:59         ` Brian Norris
     [not found]       ` <5209A1F2.80600@freescale.com>
2013-08-13  3:17         ` Brian Norris
2013-08-13  3:21           ` Huang Shijie
2013-08-13  4:10           ` Gupta, Pekon
2013-08-13  6:19             ` Huang Shijie [this message]
2013-08-12  5:42 ` [PATCH 02/10] mtd: add a helper to check the SLC/MLC nand chip Huang Shijie
2013-08-13  0:52   ` Brian Norris
2013-08-13  2:35     ` Huang Shijie
2013-08-13  2:52       ` Brian Norris
2013-08-12  5:42 ` [PATCH 03/10] mtd: print out the cell information for " Huang Shijie
2013-08-12  5:42 ` [PATCH 04/10] mtd: gpmi: rewrite the gpmi_ecc_write_oob() to support the jffs2 Huang Shijie
2013-08-12  5:42 ` [PATCH 05/10] mtd: add more comment for MTD_NANDFLASH/MTD_MLCNANDFLASH Huang Shijie
2013-08-12  5:42 ` [PATCH 06/10] mtd: fix the wrong mtd->type for nand chip Huang Shijie
2013-08-12  5:42 ` [PATCH 07/10] jffs2: init the ret with -EINVAL Huang Shijie
2013-08-12  5:42 ` [PATCH 08/10] mtd: add MTD_MLCNANDFLASH case for mtd_type_show() Huang Shijie
2013-08-13  1:05   ` Brian Norris
2013-08-13  2:20     ` Huang Shijie
2013-08-13  3:10       ` Brian Norris
2013-08-13  3:18         ` Huang Shijie
2013-08-12  5:42 ` [PATCH 09/10] mtd: add more information for the MTD_NANDFLASH case Huang Shijie
2013-08-13  1:07   ` Brian Norris
2013-08-12  5:42 ` [PATCH 10/10] mtd: add a helper to detect the nand type Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5209CFFD.8000501@freescale.com \
    --to=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=pekon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.