From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Young Subject: Re: [PATCH] network: also wait for ethernet interfaces to setup Date: Tue, 13 Aug 2013 14:22:35 +0800 Message-ID: <5209D0AB.4050103@redhat.com> References: <20130812084352.GA3445@dhcp16-109.nay.redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130812084352.GA3445-ALckc1lQpMDv8MId6FTy5BcY2uh10dtjAL8bYrjMMd8@public.gmane.org> Sender: initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: WANG Chao Cc: Harald Hoyer , initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 08/12/2013 04:43 PM, WANG Chao wrote: > We only wait for master interfaces for bridge/bonding/team/vlan case. > If none of these complex network is configured, we should wait for > ethernet interface (bootdev) instead. > --- > modules.d/40network/net-genrules.sh | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/modules.d/40network/net-genrules.sh b/modules.d/40network/net-genrules.sh > index f6b7d9a..31cd1e6 100755 > --- a/modules.d/40network/net-genrules.sh > +++ b/modules.d/40network/net-genrules.sh > @@ -74,7 +74,13 @@ command -v fix_bootif >/dev/null || . /lib/net-lib.sh > done > echo 'LABEL="net_end"' > > - for iface in $MASTER_IFACES; do > + if [ -n "$MASTER_IFACES" ]; then > + wait_ifaces=$MASTER_IFACES > + else > + wait_ifaces=$IFACES > + fi > + > + for iface in $wait_ifaces; do > if [ "$bootdev" = "$iface" ] || [ "$NEEDNET" = "1" ]; then > echo "[ -f /tmp/setup_net_${iface}.ok ]" >$hookdir/initqueue/finished/wait-$iface.sh > fi > Looks good to me, thanks for the patch. -- Thanks Dave