From: Ding Tianhong <dingtianhong@huawei.com>
To: Joe Perches <joe@perches.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/2] ipv6: fix checkpatch errors in net/ipv6/addrconf.c
Date: Tue, 13 Aug 2013 14:54:21 +0800 [thread overview]
Message-ID: <5209D81D.1070702@huawei.com> (raw)
In-Reply-To: <1376375456.1949.22.camel@joe-AO722>
On 2013/8/13 14:30, Joe Perches wrote:
> On Tue, 2013-08-13 at 14:15 +0800, Ding Tianhong wrote:
>> ERROR: Macros with complex values should be enclosed in parenthesis
>> +#define ADBG(x) printk x
> []
>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> []
>> @@ -99,7 +99,7 @@
> []
>> -#define ADBG(x) printk x
>> +#define ADBG(x) (printk x)
>
> A better way to fix this would be
> to convert the uses of ADBG and remove
> the superfluous parentheses.
>
> Something like the below but it might
> even better to remove the KERN_<LEVEL>s and
> just use pr_debug instead of ADBG...
> ---
thanks for your opinion. I think it's time to remove the tedious code and replace with pr_debug and pr_warning, I will send v2 to fix it.
prev parent reply other threads:[~2013-08-13 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 6:15 [PATCH 2/2] ipv6: fix checkpatch errors in net/ipv6/addrconf.c Ding Tianhong
2013-08-13 6:30 ` Joe Perches
2013-08-13 6:54 ` Ding Tianhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5209D81D.1070702@huawei.com \
--to=dingtianhong@huawei.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.