Re: [PATCH] xfs: call roundup_64() to calculate the min_logblks

From: Jeff Liu <jeff.liu@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
	"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: call roundup_64() to calculate the min_logblks
Date: Tue, 13 Aug 2013 15:51:37 +0800	[thread overview]
Message-ID: <5209E589.7080304@oracle.com> (raw)
In-Reply-To: <20130813065355.GB6023@dastard>

On 08/13/2013 02:53 PM, Dave Chinner wrote:

> On Tue, Aug 13, 2013 at 01:32:00PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> Replace roundup() with roundup_64() as we calculate min_logblks
>> with 64-bit divisions.  Hence, call roundup() will cause the
>> following error while compiling a 32-bit kernel:
>>
>> fs/built-in.o: In function `xfs_log_calc_minimum_size':
>> fs/xfs/xfs_log_rlimit.c:140: undefined reference to `__udivdi3'
>>
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Cc: Dave Chinner <dchinner@redhat.com>
>> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> 
> You beat me to it, Jeff. I got an email from Fengguang's build farm,
> too. :)

Hi Dave,

I'm on a longer vacations these days(until next week).  I have asked
my friend for help checking our mailing list to watch if there's any
email for me before the leaving, so I got his phone call this morning
for this bug. :)

> 
> Your fix looks good.
> 
> Reviewed-by: Dave Chinner <dchinner@redhat.com>

Thanks for your quick review!

-Jeff

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs