Re: [PATCH net-next] bonding: lacp_port_id setting for 802.3ad

[Ding Tianhong <dingtianhong@huawei.com>]

On 2013/8/13 17:20, Krisztian Ivancso wrote:
> On 08/13/2013 03:07 AM, Ding Tianhong wrote:
>> On 2013/8/12 19:19, Krisztian Ivancso wrote:
>>> >From 472fffa5a8f170daed9e4cc677af8e2560b86be2 Mon Sep 17 00:00:00 2001
>>> From: Krisztian Ivancso <github-ivan@ivancso.net>
>>> Date: Sun, 11 Aug 2013 20:30:44 +0200
>>> Subject: [PATCH net-next] bonding: lacp_port_id setting for 802.3ad ports
>>>
>>> By setting this parameter to different values on different hosts
>>> it's possible to add more Linux boxes to the same Link Aggregation.
>>>
>>
>> I think the port id was made by negotiation,  if the negotiation failed, the bonding slave
>> could not get the port id you gave, which lie on the hardware message.
> 
> Port id is currently preset to 1 in bonding driver for first slave.
> (SLAVE_AD_INFO(new_slave).id = 1; this id is used as
> actor_port_number in slave initialization)
> Port id parameter modifies just this starting value and new slaves
> get incremented port ids as in current implementation.
> 
> As I see in documentation port id (port number) set by each
> participating devices by it's own and given values are used by
> the other side.
> 
> In Cisco and Juniper documentations port id is mentioned, the value
> is derived from port number which is unique within a switch.
> 
> Cisco:
>> LACP uses the port priority with the port number to form the
>> port identifier.
> 
> Juniper:
>> The LACP port ID consists of the port priority as the two
>> most-significant octets and the port number as the two
>> least-significant octets.
> 
> 
> Cisco:
>> The LACP system ID is the combination of the LACP system priority
>> value and the MAC address.
> 
> This is why we need to use the same MAC for all participating bonding
> device in different linux boxes.
> 
> 
> The solution is tested with Cisco devices.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

ok, for example: the bonding has four slave, slave1 and slave2 aggregation to 1 group,
and slave3 and slave4 aggregtion to 2 group, how you distinguish the 1 and 2 group by initialize id.

--Ding Tianhong