Re: [PATCH 1/3] ARM: dts: omap3-igep: add pinmux node for GPIO LED configuration

[Benoit Cousson <bcousson@baylibre.com>]

Hi Javier,

On 03/08/2013 21:11, Javier Martinez Canillas wrote:
> On Thu, Jun 20, 2013 at 4:42 PM, Javier Martinez Canillas
> <javier.martinez@collabora.co.uk> wrote:
>> IGEP boards have a number of LED connected to OMAP or TWL GPIO
>> lines. The actual wiring is different on each board so each board
>> DT has need to configure the mux correctly.
>>
>> Even though it works with the current DT, the kernel complains with:
>>
>> [2.305023] leds-gpio leds.18: pins are not configured from the driver
>>
>> Add an empty pinmux_leds_pins pinctrl child node so boards can
>> override with the correct mux configuration and not depend on
>> default values for the GPIO LEDs to work.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> ---
>>   arch/arm/boot/dts/omap3-igep.dtsi |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
>> index bc48b11..55f9f61 100644
>> --- a/arch/arm/boot/dts/omap3-igep.dtsi
>> +++ b/arch/arm/boot/dts/omap3-igep.dtsi
>> @@ -68,6 +68,8 @@
>>                          0x1a2 (PIN_INPUT | MUX_MODE4)           /* mcspi1_cs2.gpio_176 */
>>                  >;
>>          };
>> +
>> +       leds_pins: pinmux_leds_pins { };

I'm just wondering what will happen if you do not override it with the 
board file?

Will we still have the warning? Because the warning is there to notify 
you that the pin config is missing so we should not prevent that to work.

Regards,
Benoit