[PATCH 1/3] ARM: dts: omap3-igep: add pinmux node for GPIO LED configuration

[PATCH 1/3] ARM: dts: omap3-igep: add pinmux node for GPIO LED configuration

[Javier Martinez Canillas]

IGEP boards have a number of LED connected to OMAP or TWL GPIO
lines. The actual wiring is different on each board so each board
DT has need to configure the mux correctly.

Even though it works with the current DT, the kernel complains with:

[2.305023] leds-gpio leds.18: pins are not configured from the driver

Add an empty pinmux_leds_pins pinctrl child node so boards can
override with the correct mux configuration and not depend on
default values for the GPIO LEDs to work.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
 arch/arm/boot/dts/omap3-igep.dtsi |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
index bc48b11..55f9f61 100644
--- a/arch/arm/boot/dts/omap3-igep.dtsi
+++ b/arch/arm/boot/dts/omap3-igep.dtsi
@@ -68,6 +68,8 @@
 			0x1a2 (PIN_INPUT | MUX_MODE4)		/* mcspi1_cs2.gpio_176 */
 		>;
 	};
+
+	leds_pins: pinmux_leds_pins { };
 };
 
 &i2c1 {
-- 
1.7.7.6

[PATCH 2/3] ARM: dts: omap3-igep0020: add mux conf for GPIO LEDs

[Javier Martinez Canillas]

The IGEPv2 has a number of GPIO LED connected to OMAP
pins. Configure these pins as output GPIO.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
 arch/arm/boot/dts/omap3-igep0020.dts |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts
index e8c4828..51c084e 100644
--- a/arch/arm/boot/dts/omap3-igep0020.dts
+++ b/arch/arm/boot/dts/omap3-igep0020.dts
@@ -16,7 +16,10 @@
 	compatible = "isee,omap3-igep0020", "ti,omap3";
 
 	leds {
+		pinctrl-names = "default";
+		pinctrl-0 = <&leds_pins>;
 		compatible = "gpio-leds";
+
 		boot {
 			 label = "omap3:green:boot";
 			 gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
@@ -54,6 +57,14 @@
 	};
 };
 
+&leds_pins {
+	pinctrl-single,pins = <
+		0x5c4 (PIN_OUTPUT | MUX_MODE4) /* etk_d12.gpio_26 */
+		0x5c6 (PIN_OUTPUT | MUX_MODE4) /* etk_d13.gpio_27 */
+		0x5c8 (PIN_OUTPUT | MUX_MODE4) /* etk_d14.gpio_28 */
+	>;
+};
+
 &i2c3 {
 	clock-frequency = <100000>;
 
-- 
1.7.7.6

Re: [PATCH 2/3] ARM: dts: omap3-igep0020: add mux conf for GPIO LEDs

[Enric Balletbo Serra]

2013/6/20 Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> The IGEPv2 has a number of GPIO LED connected to OMAP
> pins. Configure these pins as output GPIO.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>  arch/arm/boot/dts/omap3-igep0020.dts |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts
> b/arch/arm/boot/dts/omap3-igep0020.dts
> index e8c4828..51c084e 100644
> --- a/arch/arm/boot/dts/omap3-igep0020.dts
> +++ b/arch/arm/boot/dts/omap3-igep0020.dts
> @@ -16,7 +16,10 @@
>         compatible = "isee,omap3-igep0020", "ti,omap3";
>
>         leds {
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&leds_pins>;
>                 compatible = "gpio-leds";
> +
>                 boot {
>                          label = "omap3:green:boot";
>                          gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> @@ -54,6 +57,14 @@
>         };
>  };
>
> +&leds_pins {
> +       pinctrl-single,pins = <
> +               0x5c4 (PIN_OUTPUT | MUX_MODE4) /* etk_d12.gpio_26 */
> +               0x5c6 (PIN_OUTPUT | MUX_MODE4) /* etk_d13.gpio_27 */
> +               0x5c8 (PIN_OUTPUT | MUX_MODE4) /* etk_d14.gpio_28 */
> +       >;
> +};
> +
>  &i2c3 {
>         clock-frequency = <100000>;
>
> --
> 1.7.7.6
>
Tested-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>

Re: [PATCH 2/3] ARM: dts: omap3-igep0020: add mux conf for GPIO LEDs

[Javier Martinez Canillas]

On Thu, Jun 20, 2013 at 4:42 PM, Javier Martinez Canillas
<javier.martinez@collabora.co.uk> wrote:
> The IGEPv2 has a number of GPIO LED connected to OMAP
> pins. Configure these pins as output GPIO.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>  arch/arm/boot/dts/omap3-igep0020.dts |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts
> index e8c4828..51c084e 100644
> --- a/arch/arm/boot/dts/omap3-igep0020.dts
> +++ b/arch/arm/boot/dts/omap3-igep0020.dts
> @@ -16,7 +16,10 @@
>         compatible = "isee,omap3-igep0020", "ti,omap3";
>
>         leds {
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&leds_pins>;
>                 compatible = "gpio-leds";
> +
>                 boot {
>                          label = "omap3:green:boot";
>                          gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> @@ -54,6 +57,14 @@
>         };
>  };
>
> +&leds_pins {
> +       pinctrl-single,pins = <
> +               0x5c4 (PIN_OUTPUT | MUX_MODE4) /* etk_d12.gpio_26 */
> +               0x5c6 (PIN_OUTPUT | MUX_MODE4) /* etk_d13.gpio_27 */
> +               0x5c8 (PIN_OUTPUT | MUX_MODE4) /* etk_d14.gpio_28 */
> +       >;
> +};
> +
>  &i2c3 {
>         clock-frequency = <100000>;
>
> --
> 1.7.7.6
>
> --

Hi Benoit,

These patches are actually a fix since without setting the mux pin for
the GPIO makes the gpio led driver probe fails and the user leds are
not available. So, it would be possible to add these as part of the
3.11 -rc cycle fixes?

Thanks a lot and best regards,
Javier

[PATCH 3/3] ARM: dts: omap3-igep0030: add mux conf for GPIO LED

[Javier Martinez Canillas]

The IGEP COM MOdule has a GPIO LED connected to OMAP
pins. Configure this pin as output GPIO.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
 arch/arm/boot/dts/omap3-igep0030.dts |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-igep0030.dts b/arch/arm/boot/dts/omap3-igep0030.dts
index 644d053..eee3c63 100644
--- a/arch/arm/boot/dts/omap3-igep0030.dts
+++ b/arch/arm/boot/dts/omap3-igep0030.dts
@@ -16,7 +16,10 @@
 	compatible = "isee,omap3-igep0030", "ti,omap3";
 
 	leds {
+		pinctrl-names = "default";
+		pinctrl-0 = <&leds_pins>;
 		compatible = "gpio-leds";
+
 		boot {
 			 label = "omap3:green:boot";
 			 gpios = <&twl_gpio 13 GPIO_ACTIVE_LOW>;
@@ -43,6 +46,12 @@
 	};
 };
 
+&leds_pins {
+	pinctrl-single,pins = <
+		0x5b0 (PIN_OUTPUT | MUX_MODE4) /* etk_d2.gpio_16 */
+	>;
+};
+
 &gpmc {
 	ranges = <0 0 0x00000000 0x20000000>;
 
-- 
1.7.7.6

Re: [PATCH 3/3] ARM: dts: omap3-igep0030: add mux conf for GPIO LED

[Enric Balletbo Serra]

2013/6/20 Javier Martinez Canillas <javier.martinez@collabora.co.uk>:
> The IGEP COM MOdule has a GPIO LED connected to OMAP
> pins. Configure this pin as output GPIO.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>  arch/arm/boot/dts/omap3-igep0030.dts |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3-igep0030.dts b/arch/arm/boot/dts/omap3-igep0030.dts
> index 644d053..eee3c63 100644
> --- a/arch/arm/boot/dts/omap3-igep0030.dts
> +++ b/arch/arm/boot/dts/omap3-igep0030.dts
> @@ -16,7 +16,10 @@
>         compatible = "isee,omap3-igep0030", "ti,omap3";
>
>         leds {
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&leds_pins>;
>                 compatible = "gpio-leds";
> +
>                 boot {
>                          label = "omap3:green:boot";
>                          gpios = <&twl_gpio 13 GPIO_ACTIVE_LOW>;
> @@ -43,6 +46,12 @@
>         };
>  };
>
> +&leds_pins {
> +       pinctrl-single,pins = <
> +               0x5b0 (PIN_OUTPUT | MUX_MODE4) /* etk_d2.gpio_16 */
> +       >;
> +};
> +
>  &gpmc {
>         ranges = <0 0 0x00000000 0x20000000>;
>
> --
> 1.7.7.6
>
Tested-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>

Re: [PATCH 1/3] ARM: dts: omap3-igep: add pinmux node for GPIO LED configuration

[Javier Martinez Canillas]

On Thu, Jun 20, 2013 at 4:42 PM, Javier Martinez Canillas
<javier.martinez@collabora.co.uk> wrote:
> IGEP boards have a number of LED connected to OMAP or TWL GPIO
> lines. The actual wiring is different on each board so each board
> DT has need to configure the mux correctly.
>
> Even though it works with the current DT, the kernel complains with:
>
> [2.305023] leds-gpio leds.18: pins are not configured from the driver
>
> Add an empty pinmux_leds_pins pinctrl child node so boards can
> override with the correct mux configuration and not depend on
> default values for the GPIO LEDs to work.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>  arch/arm/boot/dts/omap3-igep.dtsi |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
> index bc48b11..55f9f61 100644
> --- a/arch/arm/boot/dts/omap3-igep.dtsi
> +++ b/arch/arm/boot/dts/omap3-igep.dtsi
> @@ -68,6 +68,8 @@
>                         0x1a2 (PIN_INPUT | MUX_MODE4)           /* mcspi1_cs2.gpio_176 */
>                 >;
>         };
> +
> +       leds_pins: pinmux_leds_pins { };
>  };
>
>  &i2c1 {
> --
> 1.7.7.6
>
> --

Hi Benoit,

Any feedback about this patch-set?

Thanks a lot and best regards,
Javier

Re: [PATCH 1/3] ARM: dts: omap3-igep: add pinmux node for GPIO LED configuration

[Benoit Cousson]

Hi Javier,

On 03/08/2013 21:11, Javier Martinez Canillas wrote:
> On Thu, Jun 20, 2013 at 4:42 PM, Javier Martinez Canillas
> <javier.martinez@collabora.co.uk> wrote:
>> IGEP boards have a number of LED connected to OMAP or TWL GPIO
>> lines. The actual wiring is different on each board so each board
>> DT has need to configure the mux correctly.
>>
>> Even though it works with the current DT, the kernel complains with:
>>
>> [2.305023] leds-gpio leds.18: pins are not configured from the driver
>>
>> Add an empty pinmux_leds_pins pinctrl child node so boards can
>> override with the correct mux configuration and not depend on
>> default values for the GPIO LEDs to work.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> ---
>>   arch/arm/boot/dts/omap3-igep.dtsi |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
>> index bc48b11..55f9f61 100644
>> --- a/arch/arm/boot/dts/omap3-igep.dtsi
>> +++ b/arch/arm/boot/dts/omap3-igep.dtsi
>> @@ -68,6 +68,8 @@
>>                          0x1a2 (PIN_INPUT | MUX_MODE4)           /* mcspi1_cs2.gpio_176 */
>>                  >;
>>          };
>> +
>> +       leds_pins: pinmux_leds_pins { };

I'm just wondering what will happen if you do not override it with the 
board file?

Will we still have the warning? Because the warning is there to notify 
you that the pin config is missing so we should not prevent that to work.

Regards,
Benoit

Re: [PATCH 1/3] ARM: dts: omap3-igep: add pinmux node for GPIO LED configuration

[Javier Martinez Canillas]

On Tue, Aug 13, 2013 at 1:20 PM, Benoit Cousson <bcousson@baylibre.com> wrote:
> Hi Javier,
>
>
> On 03/08/2013 21:11, Javier Martinez Canillas wrote:
>>
>> On Thu, Jun 20, 2013 at 4:42 PM, Javier Martinez Canillas
>> <javier.martinez@collabora.co.uk> wrote:
>>>
>>> IGEP boards have a number of LED connected to OMAP or TWL GPIO
>>> lines. The actual wiring is different on each board so each board
>>> DT has need to configure the mux correctly.
>>>
>>> Even though it works with the current DT, the kernel complains with:
>>>
>>> [2.305023] leds-gpio leds.18: pins are not configured from the driver
>>>
>>> Add an empty pinmux_leds_pins pinctrl child node so boards can
>>> override with the correct mux configuration and not depend on
>>> default values for the GPIO LEDs to work.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>>> ---
>>>   arch/arm/boot/dts/omap3-igep.dtsi |    2 ++
>>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi
>>> b/arch/arm/boot/dts/omap3-igep.dtsi
>>> index bc48b11..55f9f61 100644
>>> --- a/arch/arm/boot/dts/omap3-igep.dtsi
>>> +++ b/arch/arm/boot/dts/omap3-igep.dtsi
>>> @@ -68,6 +68,8 @@
>>>                          0x1a2 (PIN_INPUT | MUX_MODE4)           /*
>>> mcspi1_cs2.gpio_176 */
>>>                  >;
>>>          };
>>> +
>>> +       leds_pins: pinmux_leds_pins { };
>
>
> I'm just wondering what will happen if you do not override it with the board
> file?
>
> Will we still have the warning? Because the warning is there to notify you
> that the pin config is missing so we should not prevent that to work.
>

If you don't override on the board file you will just get the warning.

Once when I send this patches the gpio-leds driver was indeed failing
to probe because of this. I noticed this because the LED stop working
and didn't appear in /sys/class/leds/ and setting the pin mux
correctly solved the issue.

Now I just see a warning so it seems this got fixed in the meantime.

So since is not a regression probably this is v3.12 material and there
is no need to send it on the -rc series.

> Regards,
> Benoit
>

Thanks a lot and best regards,
Javier