From: Lars-Peter Clausen <lars@metafoo.de>
To: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
Cc: Peter Meerwald <pmeerw@pmeerw.net>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
jic23@cam.ac.uk
Subject: Re: [PATCH v2] iio: add Bosch BMA180 acceleration sensor driver
Date: Tue, 13 Aug 2013 13:57:20 +0200 [thread overview]
Message-ID: <520A1F20.60401@metafoo.de> (raw)
In-Reply-To: <CAGH3drr2p5dD4SXxG67QChVH1wubRCDKWaQPevQKBxej-UqsBA@mail.gmail.com>
On 08/13/2013 01:22 PM, Oleksandr Kravchenko wrote:
> On Tue, Aug 13, 2013 at 1:01 PM, Peter Meerwald <pmeerw@pmeerw.net> wrote:
>>
>>> This patch adds IIO driver for Bosch BMA180 triaxial
>>> acceleration sensor.
>>> http://omapworld.com/BMA180_111_1002839.pdf
>>
>> the DS is preliminary, more up-to-date version available
>>
>> comments inline
>>
>>> ---
>>> .../devicetree/bindings/iio/accel/bma180.txt | 35 ++
>>> drivers/iio/accel/Kconfig | 12 +
>>> drivers/iio/accel/Makefile | 2 +
>>> drivers/iio/accel/bma180.c | 635 ++++++++++++++++++++
>>> 4 files changed, 684 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/iio/accel/bma180.txt
>>> create mode 100644 drivers/iio/accel/bma180.c
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/accel/bma180.txt b/Documentation/devicetree/bindings/iio/accel/bma180.txt
>>> new file mode 100644
>>> index 0000000..e08780b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/iio/accel/bma180.txt
>>> @@ -0,0 +1,35 @@
>>> +* Bosch BMA180 triaxial acceleration sensor
>>> +
>>> +http://omapworld.com/BMA180_111_1002839.pdf
>>> +
>>> +Required properties:
>>> +
>>> + - compatible : should be "bosch,bma180"
>>> + - reg : the I2C address of the sensor
>>> +
>>> +Optional properties:
>>> +
>>> + - interrupt-parent : should be the phandle for the interrupt controller
>>> +
>>> + - interrupts : interrupt mapping for GPIO IRQ, it should by configured with
>>> + flags IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_EDGE_RISING
>>> +
>>> + - bosch,resolution : ADC resolution. Must be 130, 190, 250, 380, 500,
>>> + 990 or 1980 mcg/LSB only
>>
>> what is mcg?
> mcg is microgram (http://en.wikipedia.org/wiki/Kilogram#SI_multiples)
> How to call it more correctly?
I would be very surprised if g was gram. g is usually acceleration in this
context, 9.81m/s**2
But again same question as before, shouldn't this rather be runtime
configurable? Same for bandwidth.
- Lars
- Lars
next prev parent reply other threads:[~2013-08-13 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 9:09 [PATCH v2] iio: add Bosch BMA180 acceleration sensor driver Oleksandr Kravchenko
2013-08-13 10:01 ` Peter Meerwald
2013-08-13 11:22 ` Oleksandr Kravchenko
2013-08-13 11:57 ` Lars-Peter Clausen [this message]
2013-08-13 13:47 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520A1F20.60401@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.v.kravchenko@globallogic.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.