From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCHv3] ARM: socfpga: dts: Add support for SD/MMC Date: Tue, 13 Aug 2013 13:52:17 -0600 Message-ID: <520A8E71.4090508@wwwdotorg.org> References: <1376322589-17606-1-git-send-email-dinguyen@altera.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:49695 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757862Ab3HMTwW (ORCPT ); Tue, 13 Aug 2013 15:52:22 -0400 In-Reply-To: <1376322589-17606-1-git-send-email-dinguyen@altera.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: dinguyen@altera.com Cc: dinh.linux@gmail.com, Jaehoon Chung , Seungwon Jeon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , devicetree@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 08/12/2013 09:49 AM, dinguyen@altera.com wrote: > From: Dinh Nguyen > > Add bindings for SD/MMC for SOCFPGA. > Add "syscon" to the "altr,sys-mgr" binding. > diff --git a/Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt I think it's reasonable to define one binding as being based on another plus some additions, so, the binding, Acked-by: Stephen Warren > +Example: > + dwmmc0@ff704000 { > + compatible = "altr,socfpga-dw-mshc", "snps,dw-mshc"; > + altr,dw-mshc-sdr-timing = <0 3>; > + }; It'd be nice to provide a complete example though, rather than only including the properties that this binding adds to the base binding. > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > sysmgr@ffd08000 { > - compatible = "altr,sys-mgr"; > + compatible = "altr,sys-mgr", "syscon"; That seems like an unrelated change? From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Tue, 13 Aug 2013 13:52:17 -0600 Subject: [PATCHv3] ARM: socfpga: dts: Add support for SD/MMC In-Reply-To: <1376322589-17606-1-git-send-email-dinguyen@altera.com> References: <1376322589-17606-1-git-send-email-dinguyen@altera.com> Message-ID: <520A8E71.4090508@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/12/2013 09:49 AM, dinguyen at altera.com wrote: > From: Dinh Nguyen > > Add bindings for SD/MMC for SOCFPGA. > Add "syscon" to the "altr,sys-mgr" binding. > diff --git a/Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt I think it's reasonable to define one binding as being based on another plus some additions, so, the binding, Acked-by: Stephen Warren > +Example: > + dwmmc0 at ff704000 { > + compatible = "altr,socfpga-dw-mshc", "snps,dw-mshc"; > + altr,dw-mshc-sdr-timing = <0 3>; > + }; It'd be nice to provide a complete example though, rather than only including the properties that this binding adds to the base binding. > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > sysmgr at ffd08000 { > - compatible = "altr,sys-mgr"; > + compatible = "altr,sys-mgr", "syscon"; That seems like an unrelated change?