From: Ding Tianhong <dingtianhong@huawei.com>
To: Joe Perches <joe@perches.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Netdev <netdev@vger.kernel.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 2/3 v2] ipv6: rename ADBG() to pr_xxx()
Date: Wed, 14 Aug 2013 09:43:47 +0800 [thread overview]
Message-ID: <520AE0D3.6000402@huawei.com> (raw)
In-Reply-To: <1376412534.1949.33.camel@joe-AO722>
On 2013/8/14 0:48, Joe Perches wrote:
> On Tue, 2013-08-13 at 15:57 +0800, Ding Tianhong wrote:
>> According to Joe Perches opinions, the ADBG() was tedious and it is
>> better to remove the KERN_<LEVEL>s and use the pr_xxx() instead of ADBG().
>
> No, that's not really what I wrote.
>
> I suggested it might be better to remove the KERN_<LEVELS>
> from these ADBG uses and use pr_debug.
>
> As is, you've changed logging messages which today
> always compile away to nothing to now emit what I
> think are pretty unnecessary messages.
>
>
sorry for misunderstand your opinion, I will modify it and resend soon.:)
regards
Ding Tianhong
>
>
prev parent reply other threads:[~2013-08-14 1:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 7:57 [PATCH 2/3 v2] ipv6: rename ADBG() to pr_xxx() Ding Tianhong
2013-08-13 11:37 ` Hannes Frederic Sowa
2013-08-13 16:48 ` Joe Perches
2013-08-14 1:43 ` Ding Tianhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520AE0D3.6000402@huawei.com \
--to=dingtianhong@huawei.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.