From: Stephen Warren <swarren@wwwdotorg.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: devicetree@vger.kernel.org, rob.herring@calxeda.com,
pawel.moll@arm.com, mark.rutland@arm.com,
ian.campbell@citrix.com, rob@landley.net, robherring2@gmail.com
Subject: Re: [PATCH Resend 1/2] usb: samsung: Update Exynos ehci/ohci bindings documentation
Date: Wed, 14 Aug 2013 16:14:30 -0600 [thread overview]
Message-ID: <520C0146.5050300@wwwdotorg.org> (raw)
In-Reply-To: <1376479377-15732-1-git-send-email-sachin.kamat@linaro.org>
On 08/14/2013 05:22 AM, Sachin Kamat wrote:
> Updated the document as per the latest implementation.
> While at it also fixed some trivial typos.
> diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> EHCI
> Required properties:
> - - compatible: should be "samsung,exynos4210-ehci" for USB 2.0
> - EHCI controller in host mode.
> - - reg: physical base address of the controller and length of memory mapped
> + - compatible : should be one of the following for USB 2.0 EHCI controller
> + in host mode:
> + (a) "samsung,exynos5440-ehci" for Exynos5440 SoC
> + (b) "samsung,exynos4210-ehci" for all other Exynos4 and 5 SoCs
I'm not sure the text "in host mode" belongs there. The DT should
describe the presence of the EHCI controller HW module. Whether the
module is programmed for host mode or device mode is surely a run-time
decision, not something that would need different DT bindings?
next prev parent reply other threads:[~2013-08-14 22:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 11:22 [PATCH Resend 1/2] usb: samsung: Update Exynos ehci/ohci bindings documentation Sachin Kamat
2013-08-14 11:22 ` [PATCH Resend 2/2] usb: phy: samsung: Update usbphy documentation Sachin Kamat
2013-08-14 22:18 ` Stephen Warren
2013-08-22 16:30 ` Sachin Kamat
2013-08-14 22:14 ` Stephen Warren [this message]
2013-08-22 16:01 ` [PATCH Resend 1/2] usb: samsung: Update Exynos ehci/ohci bindings documentation Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520C0146.5050300@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree@vger.kernel.org \
--cc=ian.campbell@citrix.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=robherring2@gmail.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.