From: Mark Jackson <mpfj-list@newflow.co.uk>
To: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
jslaby@suse.cz, linux-serial@vger.kernel.org
Subject: [PATCH] OMAP: serial: Remove incorrect disabling of IER interrupt
Date: Thu, 15 Aug 2013 08:53:44 +0100 [thread overview]
Message-ID: <520C8908.4050006@newflow.co.uk> (raw)
The recent patch to add RS485 contained a bug whereby the IER
interrupt was cleared down incorrectly.
This patch fixes the problem.
Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
---
drivers/tty/serial/omap-serial.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 2706c11..2fa7b5c 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -1327,9 +1327,6 @@ serial_omap_config_rs485(struct uart_port *port, struct serial_rs485 *rs485conf)
pm_runtime_get_sync(up->dev);
spin_lock_irqsave(&up->port.lock, flags);
- up->ier &= ~(UART_IER_RLSI | UART_IER_RDI);
- serial_out(up, UART_IER, up->ier);
-
/* Disable interrupts from this port */
mode = up->ier;
up->ier = 0;
--
1.7.9.5
reply other threads:[~2013-08-15 7:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520C8908.4050006@newflow.co.uk \
--to=mpfj-list@newflow.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.