All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	barebox@lists.infradead.org
Subject: Re: [PATCH 7/8] Set model and hostname at boardlevel
Date: Thu, 15 Aug 2013 11:07:47 +0200	[thread overview]
Message-ID: <520C9A63.3050706@gmail.com> (raw)
In-Reply-To: <1376551741-16438-8-git-send-email-s.hauer@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1905 bytes --]

On 08/15/13 09:29, Sascha Hauer wrote:
> With multiboard support the compiletime generated BOARDINFO string
> gets more and more meaningless. This removes it from Kconfig and
> replaces it with a variable that can be set at boardlevel.
>
> Also many boards have a standard setting for the hostname in the
> environment. This patch also moves the standard to C code by calling
> barebox_set_hostname().
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
[...]
> diff --git a/arch/arm/mach-mvebu/armada-370-xp.c b/arch/arm/mach-mvebu/armada-370-xp.c
> index 24720d5..b1d148d 100644
> --- a/arch/arm/mach-mvebu/armada-370-xp.c
> +++ b/arch/arm/mach-mvebu/armada-370-xp.c
> @@ -100,6 +100,9 @@ static int armada_370_xp_init_soc(void)
>   {
>   	unsigned long phys_base, phys_size;
>
> +	barebox_set_model("Marvell Armada");

Marvell Armada SoC family comprises more than just 370 and XP. I suggest
to name it "Marvell Armada 370/XP" instead. More Armada SoCs may add to
this init, but right now it's only those two.

> +	barebox_set_hostname("armada");

No need to change this though.

> +
>   	armada_370_xp_init_clocks();
>   	clkdev_add_physbase(tclk, (unsigned int)ARMADA_370_XP_TIMER_BASE, NULL);
>   	add_generic_device("mvebu-timer", DEVICE_ID_SINGLE, NULL,
> diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
> index 2ec175a..d114675 100644
> --- a/arch/arm/mach-mvebu/kirkwood.c
> +++ b/arch/arm/mach-mvebu/kirkwood.c
> @@ -85,6 +85,9 @@ static int kirkwood_init_soc(void)
>   {
>   	unsigned long phys_base, phys_size;
>
> +	barebox_set_model("Marvell kirkwood");

typo s/kirk/Kirk/

> +	barebox_set_hostname("kirkwood");
> +
>   	kirkwood_init_clocks();
>   	clkdev_add_physbase(tclk, (unsigned int)KIRKWOOD_TIMER_BASE, NULL);
>   	add_generic_device("orion-timer", DEVICE_ID_SINGLE, NULL,

Also, corresponding changes for Dove are missing (diff below).

Sebastian

[-- Attachment #2: bb-boardname.dove.diff --]
[-- Type: text/x-patch, Size: 442 bytes --]

diff --git a/arch/arm/mach-mvebu/dove.c b/arch/arm/mach-mvebu/dove.c
index 16ee116..bb69e64 100644
--- a/arch/arm/mach-mvebu/dove.c
+++ b/arch/arm/mach-mvebu/dove.c
@@ -121,6 +121,9 @@ static int dove_init_soc(void)
 {
 	unsigned long phys_base, phys_size;
 
+	barebox_set_model("Marvell Dove");
+	barebox_set_hostname("dove");
+
 	dove_remap_mc_regs();
 	dove_init_clocks();
 	clkdev_add_physbase(tclk, (unsigned int)DOVE_TIMER_BASE, NULL);

[-- Attachment #3: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2013-08-15  9:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-15  7:28 [PATCH] move BOARDINFO to globalvar Sascha Hauer
2013-08-15  7:28 ` [PATCH 1/8] globalvar: Allow to set initial value Sascha Hauer
2013-08-15  7:28 ` [PATCH 2/8] Add a global.version variable Sascha Hauer
2013-08-15  7:28 ` [PATCH 3/8] globalvar: move globalvar init to pure_initcall Sascha Hauer
2013-08-15  7:28 ` [PATCH 4/8] remove remaining references of CONFIG_BOARDINFO Sascha Hauer
2013-08-15  7:28 ` [PATCH 5/8] introduce barebox_set_model Sascha Hauer
2013-08-15  7:28 ` [PATCH 6/8] Make hostname available to C Code Sascha Hauer
2013-08-15  7:29 ` [PATCH 7/8] Set model and hostname at boardlevel Sascha Hauer
2013-08-15  7:39   ` Alexander Shiyan
2013-08-15  9:13     ` Sascha Hauer
2013-08-15  9:07   ` Sebastian Hesselbarth [this message]
2013-08-15  9:13     ` Sascha Hauer
2013-08-15  9:19       ` Sebastian Hesselbarth
2013-08-15  7:29 ` [PATCH 8/8] export model as globalvar Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520C9A63.3050706@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.