From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libsecret: New package
Date: Thu, 15 Aug 2013 07:41:12 -0300 [thread overview]
Message-ID: <520CB048.6060707@zacarias.com.ar> (raw)
In-Reply-To: <1376562685-17191-1-git-send-email-markos.chandras@imgtec.com>
On 08/15/2013 07:31 AM, Markos Chandras wrote:
> +config BR2_PACKAGE_LIBSECRET
> + bool "libsecret"
> + select BR2_PACKAGE_LIBGLIB2
> + help
> + libsecret is a library for storing and retrieving passwords and other
> + secrets. It communicates with the "Secret Service" using DBus.
> + gnome-keyring and ksecretservice are both implementations of a Secret
> + Service.
> +
> + https://wiki.gnome.org/Libsecret
You forgot to inherit LIBGLIB2 depends (WCHAR, THREADS) and add a
comment on why it's unavailable when both aren't available.
Other than that it looks good in principle (untested).
Regards.
next prev parent reply other threads:[~2013-08-15 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 10:31 [Buildroot] [PATCH] libsecret: New package Markos Chandras
2013-08-15 10:41 ` Gustavo Zacarias [this message]
2013-08-15 10:56 ` Markos Chandras
2013-08-15 11:04 ` Gustavo Zacarias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520CB048.6060707@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.