From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, marex@denx.de
Subject: Re: [PATCH] i2c: mxs: Better error handling
Date: Thu, 15 Aug 2013 13:09:41 +0200 [thread overview]
Message-ID: <520CB6F5.1040309@free-electrons.com> (raw)
In-Reply-To: <20130815100331.GD2987@katana>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi Wolfram,
On 15/08/2013 12:03, Wolfram Sang wrote:
> On Wed, Jul 03, 2013 at 10:59:22AM +0200, Alexandre Belloni wrote:
>> This patch fixes two error handling cases in mxs_i2c_xfer_msg():
>>
>> - in PIO mode, mxs_i2c_pio_setup_xfer() may return an error but
i2c->cmd_err
>> will not be set so mxs_i2c_xfer_msg() fails silently.
>>
>> - in DMA mode, mxs_i2c_dma_setup_xfer() may return an error and have
>> i2c->cmd_err set to -ENXIO. In that case, we want to go through the
>> MXS_I2C_CTRL1_CLR_GOT_A_NAK before returning.
>
> A short explanation why we want that would be perfect.
>
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
> I'd like to postpone this until I applied Marek's PIO rework. Could you
> respin after that?
>
Actually, this patch won't be needed after Marek's PIO rework. You can
drop it now.
- --
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJSDLb1AAoJEKbNnwlvZCyzBOoQAL5NbGfmv2toVVcOHIkGpe0X
L+4NqviBObeP2Kh/JWPm8zfuLhIHTU+MNGxFpL5JLzGh+5NVqEA5M7bQjwxmZxPS
OCEgzKwMzrTbxM3mOAxALO3LtEOUa6xBzzcKbaeWq48m2yA2KRt9niEqvN+cAHVl
rqFyrcv54AUOfdMS923bBNqMpTdpCmdy164msFV+yQqljd4Igg0T54KqmHmw2+4m
asfJtDAa674sGizZdB0bSZTo0pGhD2TJEdqU17rsDa/PruFgI8/lw4LOXtpL017M
zwx7miO6gkUymEiyOtfufOBkEUSfPmOPd/BcasgAs8loo01IPttn2vMWAV+Pku+D
XzbvFvSrlHiMQze6GCejv3W5dMySyDMnWma5ZGJ9DXkzE677UK7i7ehZSxn4huVn
w5JNgXfCsOexjTRmtoUad652kQl/GKDL5DdJr75wcZzp/6RfyGz3fu4mfUYiqFue
vW/Xbkswc334v2ueuQsdzlEEFfGaiddlsyHHfEEOsdO7djoGRXBoUxI+S1bDFdLO
WXCLRO11Ju0IXiTQ9uBBSibP0nSmu9W6/s1Ufp1F3OWqAj+H7CEZpqjg4hQkMIh+
997svOMknIuJzLhvBQbGj8FJ1FQhNDRaF49tFrpBhZaXp3a+a1rS31kZaoTx2etT
35VZG9zLAOGkfCPU3JEu
=bjCC
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2013-08-15 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 8:59 [PATCH] i2c: mxs: Better error handling Alexandre Belloni
2013-07-03 8:59 ` Alexandre Belloni
[not found] ` <1372841962-26310-1-git-send-email-alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-08-15 10:03 ` Wolfram Sang
2013-08-15 10:03 ` Wolfram Sang
2013-08-15 11:09 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520CB6F5.1040309@free-electrons.com \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.