Re: [PATCH 0/3] stdinc-related build fixes.

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 15/08/13 20:49, Patrick Welche wrote:
> On Thu, Aug 15, 2013 at 02:25:04PM +0100, Tim Deegan wrote:
>> These three patches tidy some of the xen build runes around the use of
>> nostdinc.
>>
>> Patch 3/3 hasn't yet been tested on an actual NetBSD box,
>> so I'd appreciate it if Patrick would give it a go.  Apart from that,
>> I've tested with every GCC I can lay my hands on (and clang 3.0),
>> building x86 and ARM.
> Your changes allowed a successful "gmake xen", thank you!
>
> If we want to carry on helping smooth out the build, I was surprised
> by "gmake install xen" giving
>
>   [ -d //boot ] || install -d -m0755 -p //boot
>   install: //boot exists but is not a directory
>
> given that I had configured with --prefix=/usr/local/xen.
>
> /boot isn't a directory, it's my second stage bootloader, so I
> would rather not loose it ;-) Start another thread?
>
> Cheers,
>
> Patrick

As for your boot problem, that will be something not correctly setting
the DESTDIR make variable.

Is gmake having a fit with the "local variable" syntax in xen/Makefile

.PHONY: _install
_install: D=$(DESTDIR)
_install: T=$(notdir $(TARGET))
_install: Z=$(CONFIG_XEN_INSTALL_SUFFIX)
_install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX)
        [ -d $(D)/boot ] || $(INSTALL_DIR) $(D)/boot
        $(INSTALL_DATA) $(TARGET)$(Z) $(D)/boot/$(T)-$(XEN_FULLVERSION)$(Z)

or is something else not setting DESTDIR higher up?

~Andrew

>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel