Re: [Qemu-devel] [PATCH v2 for 1.6] w32: Add missing version.o to all executables (fix regression)

[Stefan Weil <sw@weilnetz.de>]

[-- Attachment #1: Type: text/plain, Size: 2175 bytes --]

Am 16.08.2013 00:19, schrieb Michael Roth:
> Quoting Stefan Weil (2013-08-08 13:18:07)
>> > QEMU executables for w32, w64 had included meta information built from
>> > version.rc. These rules were changed several times some months ago.
>> > 
>> > The latest version added version.o to the tools, but not to the system
>> > emulations.
>> > 
>> > This patch adds the meta information to all system emulations again.
>> > 
>> > Signed-off-by: Stefan Weil <sw@weilnetz.de>
> I seem to be getting build errors with this patch when doing a Fedora 18 mingw
> crossbuild. I thought it was specific to qemu-ga so I disabled it to confirm
> and it looks like version.o is never being built, so all targets fail when
> linking.
>
> Reverting this patch seems to fix things
>

That's strange. Exactly the same command line works on Debian wheezy.
version.o is built right at the beginning:

...
QOM debugging     yes
  GEN   x86_64-softmmu/config-devices.mak
  GEN   qemu-options.def
  GEN   config-host.h
  GEN   qmp-commands.h
  GEN   qapi-types.h
  GEN   qapi-visit.h
  GEN   trace/generated-events.h
  GEN   trace/generated-tracers.h
  GEN   tests/test-qapi-types.h
  GEN   tests/test-qapi-visit.h
  GEN   tests/test-qmp-commands.h
  GEN   config-all-devices.mak
  RC    /home/stefan/src/qemu/qemu.org/spelling/version.o
rm /home/stefan/src/qemu/qemu.org/spelling/config-host.h-timestamp
  GEN   config-host.h
  GEN   qemu-monitor.texi
  GEN   qemu-img-cmds.texi
...

Here are the dependency rules which should trigger building of version.o:

$ grep version-.*obj Makefile* *mak
Makefile:Makefile: $(version-obj-y) $(version-lobj-y)
Makefile.objs:version-obj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.o
Makefile.objs:version-lobj-$(CONFIG_WIN32) += $(BUILD_DIR)/version.lo

Could you please check the values of version-obj-y, version-lobj-y?
Do you use a special make program? Do you get the same problem when
running make without -j4 (no parallel build)?

My patch was a hack for 1.6, but I did not expect that it might cause
any problems. A better solution would extend version.rc and compile
it each time when linking, so version.o can include build information.

Regards,
Stefan


[-- Attachment #2: Type: text/html, Size: 4161 bytes --]