From: Josh Durgin <josh.durgin@inktank.com>
To: Loic Dachary <loic@dachary.org>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: Show outdated diffs on github
Date: Fri, 16 Aug 2013 00:01:20 -0700 [thread overview]
Message-ID: <520DCE40.90505@inktank.com> (raw)
In-Reply-To: <520DCA85.1020208@dachary.org>
On 08/15/2013 11:45 PM, Loic Dachary wrote:
> Hi Josh,
>
> From https://github.com/ceph/ceph/pull/504 I see that your comments persisted despite a rebase and show as
>
> jdurgin discussed an outdated diff 8 hours ago
>
> I would like to do the same but when I comment inline, it shows differently and gets trashed by a rebase. I'm curious to learn how you do it :-)
The interface isn't ideal - if you comment on the pull request diff
(i.e. https://github.com/ceph/ceph/pull/504/files) instead of the
individual commits, then your comments will stay associated with the
pull request (and still appear on new versions of the branch if the
line they're on didn't change).
Josh
next prev parent reply other threads:[~2013-08-16 7:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 6:45 Show outdated diffs on github Loic Dachary
2013-08-16 7:01 ` Josh Durgin [this message]
2013-08-16 8:00 ` Loic Dachary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520DCE40.90505@inktank.com \
--to=josh.durgin@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=loic@dachary.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.