From: Tang Chen <tangchen@cn.fujitsu.com>
To: Joe Perches <joe@perches.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
lenb@kernel.org, rjw@sisk.pl, liwanp@linux.vnet.ibm.com,
tj@kernel.org, akpm@linux-foundation.org, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 3/6] acpi cleanup: Use pr_info() instead of printk() in arch/x86/mm/srat.c
Date: Fri, 16 Aug 2013 15:58:44 +0800 [thread overview]
Message-ID: <520DDBB4.60801@cn.fujitsu.com> (raw)
In-Reply-To: <1376637949.1947.3.camel@joe-AO722>
Hi Joe,
On 08/16/2013 03:25 PM, Joe Perches wrote:
> On Fri, 2013-08-16 at 15:06 +0800, Tang Chen wrote:
>> arch/x86/mm/srat.c
>
> I think it'd be better to use pr_fmt
> with the conversions to pr_info and pr_err.
>
> pr_fmt can prefix the appropriate srat: and
> so the format strings do not need it.
>
> Something like:
> ---
> arch/x86/mm/srat.c | 31 ++++++++++++++++---------------
> 1 file changed, 16 insertions(+), 15 deletions(-)
>
> diff --git a/arch/x86/mm/srat.c b/arch/x86/mm/srat.c
> index cdd0da9..350b4c5 100644
> --- a/arch/x86/mm/srat.c
> +++ b/arch/x86/mm/srat.c
> @@ -9,6 +9,8 @@
> * are in one chunk. Holes between them will be included in the node.
> */
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
OK, will update the patches.
Thanks. :)
next prev parent reply other threads:[~2013-08-16 7:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 7:06 [PATCH 0/6] acpi: Fix and cleanup in acpi Tang Chen
2013-08-16 7:06 ` [PATCH 1/6] acpi, numa, mem_hotplug: Kill save_add_info() Tang Chen
2013-08-19 18:48 ` Toshi Kani
2013-08-16 7:06 ` [PATCH 2/6] acpi, numa, mem_hotplug: Print Hot-Pluggable Field in SRAT Tang Chen
2013-08-19 18:48 ` Toshi Kani
2013-08-16 7:06 ` [PATCH 3/6] acpi cleanup: Use pr_info() instead of printk() in arch/x86/mm/srat.c Tang Chen
2013-08-16 7:25 ` Joe Perches
2013-08-16 7:58 ` Tang Chen [this message]
2013-08-16 10:11 ` Tang Chen
2013-08-16 10:11 ` [PATCH 4/6] acpi cleanup: Use pr_err() " Tang Chen
2013-08-19 18:53 ` [PATCH 3/6] acpi cleanup: Use pr_info() " Toshi Kani
2013-08-16 7:06 ` [PATCH 4/6] acpi cleanup: Use pr_err() " Tang Chen
2013-08-16 7:06 ` [PATCH 5/6] acpi: Check if @id is NULL in acpi_table_parse() Tang Chen
2013-08-19 19:29 ` Toshi Kani
2013-08-16 7:06 ` [PATCH 6/6] acpi: Return -ENOENT in acpi_table_parse() and fix wrong comment Tang Chen
2013-08-19 19:29 ` Toshi Kani
2013-08-20 1:19 ` Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520DDBB4.60801@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mingo@redhat.com \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.