Show outdated diffs on github

Show outdated diffs on github

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Hi Josh,

From https://github.com/ceph/ceph/pull/504 I see that your comments persisted despite a rebase and show as 

 jdurgin discussed an outdated diff 8 hours ago 

I would like to do the same but when I comment inline, it shows differently and gets trashed by a rebase. I'm curious to learn how you do it :-)

Cheers

-- 
Loïc Dachary, Artisan Logiciel Libre
All that is necessary for the triumph of evil is that good people do nothing.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]

Re: Show outdated diffs on github

[Josh Durgin]

On 08/15/2013 11:45 PM, Loic Dachary wrote:
> Hi Josh,
>
>  From https://github.com/ceph/ceph/pull/504 I see that your comments persisted despite a rebase and show as
>
>   jdurgin discussed an outdated diff 8 hours ago
>
> I would like to do the same but when I comment inline, it shows differently and gets trashed by a rebase. I'm curious to learn how you do it :-)

The interface isn't ideal - if you comment on the pull request diff
(i.e. https://github.com/ceph/ceph/pull/504/files) instead of the
individual commits, then your comments will stay associated with the
pull request (and still appear on new versions of the branch if the
line they're on didn't change).

Josh

Re: Show outdated diffs on github

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]

Thanks for the tip !

On 16/08/2013 09:01, Josh Durgin wrote:
> On 08/15/2013 11:45 PM, Loic Dachary wrote:
>> Hi Josh,
>>
>>  From https://github.com/ceph/ceph/pull/504 I see that your comments persisted despite a rebase and show as
>>
>>   jdurgin discussed an outdated diff 8 hours ago
>>
>> I would like to do the same but when I comment inline, it shows differently and gets trashed by a rebase. I'm curious to learn how you do it :-)
> 
> The interface isn't ideal - if you comment on the pull request diff
> (i.e. https://github.com/ceph/ceph/pull/504/files) instead of the
> individual commits, then your comments will stay associated with the
> pull request (and still appear on new versions of the branch if the
> line they're on didn't change).
> 
> Josh

-- 
Loïc Dachary, Artisan Logiciel Libre
All that is necessary for the triumph of evil is that good people do nothing.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]