From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f44.google.com (mail-pb0-f44.google.com [209.85.160.44]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id D45832C0184 for ; Fri, 16 Aug 2013 20:15:44 +1000 (EST) Received: by mail-pb0-f44.google.com with SMTP id xa7so1839271pbc.17 for ; Fri, 16 Aug 2013 03:15:42 -0700 (PDT) Message-ID: <520DFBC8.4040509@ozlabs.ru> Date: Fri, 16 Aug 2013 20:15:36 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 To: Wei Yang Subject: Re: [PATCH 2/2] powerpc/iommu: check dev->iommu_group before remove a device from iommu_group References: <1376647687-20550-1-git-send-email-weiyang@linux.vnet.ibm.com> <1376647687-20550-3-git-send-email-weiyang@linux.vnet.ibm.com> In-Reply-To: <1376647687-20550-3-git-send-email-weiyang@linux.vnet.ibm.com> Content-Type: text/plain; charset=KOI8-R Cc: paulus@au1.ibm.com, benh@au1.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/16/2013 08:08 PM, Wei Yang wrote: > --- > arch/powerpc/kernel/iommu.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c > index b20ff17..5abf7c3 100644 > --- a/arch/powerpc/kernel/iommu.c > +++ b/arch/powerpc/kernel/iommu.c > @@ -1149,7 +1149,8 @@ static int iommu_bus_notifier(struct notifier_block *nb, > case BUS_NOTIFY_ADD_DEVICE: > return iommu_add_device(dev); > case BUS_NOTIFY_DEL_DEVICE: > - iommu_del_device(dev); > + if (dev->iommu_group) > + iommu_del_device(dev); > return 0; > default: > return 0; > This one seems redundant, no? -- Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753623Ab3HPKPs (ORCPT ); Fri, 16 Aug 2013 06:15:48 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:61259 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257Ab3HPKPn (ORCPT ); Fri, 16 Aug 2013 06:15:43 -0400 Message-ID: <520DFBC8.4040509@ozlabs.ru> Date: Fri, 16 Aug 2013 20:15:36 +1000 From: Alexey Kardashevskiy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Wei Yang CC: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, benh@au1.ibm.com, paulus@au1.ibm.com Subject: Re: [PATCH 2/2] powerpc/iommu: check dev->iommu_group before remove a device from iommu_group References: <1376647687-20550-1-git-send-email-weiyang@linux.vnet.ibm.com> <1376647687-20550-3-git-send-email-weiyang@linux.vnet.ibm.com> In-Reply-To: <1376647687-20550-3-git-send-email-weiyang@linux.vnet.ibm.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16/2013 08:08 PM, Wei Yang wrote: > --- > arch/powerpc/kernel/iommu.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c > index b20ff17..5abf7c3 100644 > --- a/arch/powerpc/kernel/iommu.c > +++ b/arch/powerpc/kernel/iommu.c > @@ -1149,7 +1149,8 @@ static int iommu_bus_notifier(struct notifier_block *nb, > case BUS_NOTIFY_ADD_DEVICE: > return iommu_add_device(dev); > case BUS_NOTIFY_DEL_DEVICE: > - iommu_del_device(dev); > + if (dev->iommu_group) > + iommu_del_device(dev); > return 0; > default: > return 0; > This one seems redundant, no? -- Alexey