From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Peres Subject: Re: [PATCH] nouveau reclocking on nv40 not working since 77145f1cbdf8d28b46ff8070ca749bad821e0774 Date: Fri, 16 Aug 2013 06:23:27 -0400 Message-ID: <520DFD9F.1070006@labri.fr> References: <23735105.M9MNGeX3Gc@pali> <201308151946.26609@pali> <520D54CA.4050001@labri.fr> <1577797.nVIM0OkmpX@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1577797.nVIM0OkmpX@pali> Sender: linux-kernel-owner@vger.kernel.org To: =?ISO-8859-1?Q?Pali_Roh=E1r?= Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ben Skeggs List-Id: dri-devel@lists.freedesktop.org On 16/08/2013 03:16, Pali Roh=E1r wrote: > On Thursday 15 August 2013 18:23:06 Martin Peres wrote: >> On 15/08/2013 13:46, Pali Roh=E1r wrote: >>> On Tuesday 13 August 2013 11:28:01 Pali Roh=E1r wrote: >>>> Hello, >>>> >>>> in commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was >>>> introduced error which cause that on my Nvidia 6600GT card >>>> reclocking not working anymore. There is missing assigment of >>>> return value from pll_calc to ret. >>>> >>>> After this patch reclocking on my card working fine again. >>>> Above broken commit was introduced in kernel 3.7, so consider >>>> backporting this patch to older kernels too. >>>> >>>> Signed-off-by: Pali Roh=E1r >>>> >>>> diff --git a/drivers/gpu/drm/nouveau/nv40_pm.c >>>> b/drivers/gpu/drm/nouveau/nv40_pm.c index 3af5bcd..625f80d >>>> 100644 >>>> --- a/drivers/gpu/drm/nouveau/nv40_pm.c >>>> +++ b/drivers/gpu/drm/nouveau/nv40_pm.c >>>> @@ -131,7 +131,7 @@ nv40_calc_pll(struct drm_device *dev, u32 >>>> reg, struct nvbios_pll *pll, if (clk < pll->vco1.max_freq) >>>> >>>> pll->vco2.max_freq =3D 0; >>>> >>>> - pclk->pll_calc(pclk, pll, clk, &coef); >>>> + ret =3D pclk->pll_calc(pclk, pll, clk, &coef); >>>> >>>> if (ret =3D=3D 0) >>>> =09 >>>> return -ERANGE; >>> Martin, can you look at another problem with my graphics card? >> As I told you before, I'm away from my computers, so I cannot test t= he >> patch. However, >> this one seems quite obvious and should be pushed. Thanks. > Yes, look at that diff of that problematic commit and you will see th= at ret > here is missing. It is possible to push this patch to 3.11? Please make a proper patch (generated by git format-patch or git=20 send-email) and Ben will push it. You add my Signed-off-by: Martin Peres Cheers