From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55100)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VAHkz-0002tW-LI
	for qemu-devel@nongnu.org; Fri, 16 Aug 2013 06:59:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VAHks-0005kW-UZ
	for qemu-devel@nongnu.org; Fri, 16 Aug 2013 06:59:49 -0400
Message-ID: <520E061B.9020405@suse.de>
Date: Fri, 16 Aug 2013 12:59:39 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1376328163-7323-1-git-send-email-afaerber@suse.de>
In-Reply-To: <1376328163-7323-1-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFT qom-cpu for-next] gdbstub: Fix
 gdb_register_coprocessor() register counting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-stable <qemu-stable@nongnu.org>, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Anthony Liguori <anthony@codemonkey.ws>

Am 12.08.2013 19:22, schrieb Andreas F=C3=A4rber:
> Commit a0e372f0c49ac01faeaeb73a6e8f50e8ac615f34 reorganized the registe=
r
> counting for GDB. While it seems correct not to let the total number of
> registers skyrocket in an SMP scenario through a static variable, the
> distinction between total register count and 'g' packet register count
> (last_reg vs. num_g_regs) got lost among the way.
>=20
> Fix this by introducing CPUState::gdb_num_g_regs and using that in
> gdb_handle_packet().
>=20
> Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Cc: qemu-stable@nongnu.org (for 1.6)
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> ---
>  gdbstub.c         | 6 ++++--
>  include/qom/cpu.h | 2 ++
>  qom/cpu.c         | 2 +-
>  3 files changed, 7 insertions(+), 3 deletions(-)

Ping!

Peter, could you verify the ARM FP registers are now as expected?

Max, could you test xtensa as the special case?

Thanks,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg