From: Balaji T K <balajitk@ti.com>
To: cjb@laptop.org, linux-mmc@vger.kernel.org
Cc: Felipe Balbi <balbi@ti.com>,
linux-omap@vger.kernel.org, a-bindra@ti.com,
Tony Lindgren <tony@atomide.com>,
ezequiel.garcia@free-electrons.com, nm@ti.com
Subject: Re: [PATCH] mmc: omap_hsmmc: fix dependency on indirect header inclusion
Date: Fri, 16 Aug 2013 21:59:54 +0530 [thread overview]
Message-ID: <520E5382.1090408@ti.com> (raw)
In-Reply-To: <1373548145-3833-1-git-send-email-balbi@ti.com>
On Thursday 11 July 2013 06:39 PM, Felipe Balbi wrote:
> omap_hsmmc.c depends on <linux/sizes.h> being
> included indirectly by another header. Once we
> enable COMPILE_TEST for this driver, we might
> compile under architectures which won't include
> <linux/sizes.h> for us. In fact, one such case
> is x86.
>
> In order to prevent compile breakages, let's
> explicitly include <linux/sizes.h>
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>
> This should be applied before http://marc.info/?l=linux-omap&m=137347241524118&w=2
> in order to maintain bisectability.
Thanks Felipe
Acked-by: Balaji T K <balajitk@ti.com>
>
> cheers
>
> drivers/mmc/host/omap_hsmmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 1865321..c937ffc 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -21,6 +21,7 @@
> #include <linux/debugfs.h>
> #include <linux/dmaengine.h>
> #include <linux/seq_file.h>
> +#include <linux/sizes.h>
> #include <linux/interrupt.h>
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
>
next prev parent reply other threads:[~2013-08-16 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 13:09 [PATCH] mmc: omap_hsmmc: fix dependency on indirect header inclusion Felipe Balbi
2013-08-16 16:29 ` Balaji T K [this message]
2013-08-25 2:51 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520E5382.1090408@ti.com \
--to=balajitk@ti.com \
--cc=a-bindra@ti.com \
--cc=balbi@ti.com \
--cc=cjb@laptop.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.