From: Kumar Gaurav <kumargauravgupta3@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: Explanation Needed
Date: Fri, 16 Aug 2013 18:16:58 +0000 [thread overview]
Message-ID: <520E69CA.9060102@gmail.com> (raw)
On Friday 16 August 2013 11:28 PM, Sarah Sharp wrote:
> On Fri, Aug 16, 2013 at 11:09:12PM +0530, Kumar Gaurav wrote:
>> Hi Sarah,
>>
>> I was just reading through xhci driver's code and found something
>> which i'm unable to understand use of.
>> Please help me understanding them
>>
>> 1.use of struct xhci_hcd in function xhci_readl
>> function definition doesn't uses this type of argument
>> static inline unsigned int xhci_readl(const struct xhci_hcd *xhci,__le32 __iomem *regs)
>> {
>> return readl(regs);
>> }
> The function used to print when registers were read, and thus needed the
> xhci_hcd argument. It's no longer used, so if you want to submit a
> patch to remove that argument, I would take it. Please look at
> Documentation/SubmittingPatches if you've never submitted a Linux kernel
> patch before.
>
> Sarah Sharp
Please correct me if i'm wrong, as far as i read "*regs" points to the
location of register to be read. Then what is use of xhci_hcd?
I'll be sending patch for the same.
Regards
Kumar gaurav
next reply other threads:[~2013-08-16 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 18:16 Kumar Gaurav [this message]
2013-08-16 18:27 ` Explanation Needed Sarah Sharp
2013-08-16 18:45 ` Kumar Gaurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520E69CA.9060102@gmail.com \
--to=kumargauravgupta3@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.