From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D4BC10F0E for ; Fri, 12 Apr 2019 13:18:54 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 29A632054F for ; Fri, 12 Apr 2019 13:18:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="aK0yV7c8"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="17OXwnDr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29A632054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B2C9C1B129; Fri, 12 Apr 2019 15:18:51 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 490B37EC7 for ; Fri, 12 Apr 2019 15:18:50 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CB91720D7C; Fri, 12 Apr 2019 09:18:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 12 Apr 2019 09:18:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=4JTYeHwFJJRF5bayE1C0cx6KRErENrljx8ZxYafITGY=; b=aK0yV7c8ZgH/ aXeusFERbtK/TBcibRXYASTCpp/LmN2ZiwZ/pQ1rmOp37ZHs4Mj4cNPIA3b8JB2j sxwRSi+JfUWr9xUUSHuWlCJ9y37DHVGYgYq8/6f7Kqdh37FgUjboXl7ufm9LPh0A t6Ec0gOcKJQ75Jpj+OLnWp415s+WltY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=4JTYeHwFJJRF5bayE1C0cx6KRErENrljx8ZxYafIT GY=; b=17OXwnDr6iydaixg1ajLoIBsFL2/wQN38yl04YmnLJRKH9hTt9l7O27cO KrGixRSL2JlgrLsRrz/5vPQ4lFjsiw4N7FIdg60WcJCxomrkpDbdzAsfr8OibjBP Y6iw77DoOsHKSJJakwBX7bi5AGQkVCyFgy4a8wP2ROsYplE0Bcc63zEl+qUjH7Le 83D+RN7aCiP2HLiF2Uwro8jTX4OaWztLe3NqyfFo1gXcXsKlvwFk0bCcCxKlUtaj nw7+kaUbmC4TgvKMaCXni6usne3HQ1bfxA3nyp4uvadIlub0uCpmvtYrMSWoGme7 cBB5JD6cBEsZV7kTar6sO9qQdvimQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrvddugdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6892FE4173; Fri, 12 Apr 2019 09:18:47 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Ferruh Yigit , David Marchand , arybchenko@solarflare.com, "Stokes, Ian" Date: Fri, 12 Apr 2019 15:18:46 +0200 Message-ID: <5210965.CNSgfQvn2d@xps> In-Reply-To: <20190319105401.0974a7ac@shemminger-XPS-13-9360> References: <20190319105401.0974a7ac@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/03/2019 18:54, Stephen Hemminger: > My preference would be: > 1. Make all DPDK drivers consistent in usage of current statistic values. > 2. Propose an enhancement to have new ethdev statistics match some pre-existing > standard like SNMP or other RFC. This patch is about basic stats. What would be different if looking at SNMP or other? > 3. Reduce custom (xstats) values by using #2. Leave it for driver specific stuff. > > I.e: don't modify existing API at all, make a new one. This patch does not modify the API.