All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-can@vger.kernel.org
Subject: Re: [PATCH can-utils] Don't overwrite PREFIX and DESTDIR when provided via the environment
Date: Sun, 18 Aug 2013 13:02:29 +0200	[thread overview]
Message-ID: <5210A9C5.5070309@hartkopp.net> (raw)
In-Reply-To: <520FCFDD.7010308@pengutronix.de>

On 17.08.2013 21:32, Marc Kleine-Budde wrote:
> On 08/17/2013 09:28 PM, Uwe Kleine-König wrote:
>> For creating a Debian package providing PREFIX and DESTDIR via the
>> environment is the easiest option. So use ?= to assign these two
>> variables to honor the values in the environment.
> 
> I suggest to use autotools.
> 
> ./configure && make && make install
> 

Today i like the possibility to use autotools or just to say 'make && make
install' without autotools.

You may choose for the Debian package the build process which is more appropriate.

>
> -DESTDIR =
> -PREFIX = /usr/local
> +DESTDIR ?=
> +PREFIX ?= /usr/local
>

1. good idea - I already pushed it to the git tree

2. I wonder if we should doublecheck the target directories when making it a
real Debian package

e.g. the majority of tools should go into /usr/bin then

But some tools that require root rights should go to /usr/sbin like cangw,
isotptun, slcan_attach, slcand

Or should they stay in /usr/bin and lead to an error when the admin rights are
not granted??

BR,
Oliver




  reply	other threads:[~2013-08-18 11:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-17 19:28 [PATCH can-utils] Don't overwrite PREFIX and DESTDIR when provided via the environment Uwe Kleine-König
2013-08-17 19:32 ` Marc Kleine-Budde
2013-08-18 11:02   ` Oliver Hartkopp [this message]
2013-08-18 20:49     ` Uwe Kleine-König
2013-08-18 21:36       ` Marc Kleine-Budde
2013-08-19  8:24         ` Marc Kleine-Budde
2013-08-19  8:37         ` Uwe Kleine-König
2013-08-19 17:23           ` Oliver Hartkopp
2013-08-19 19:16             ` Marc Kleine-Budde
2013-08-20  5:29               ` Oliver Hartkopp
2013-08-20  6:55                 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5210A9C5.5070309@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.