From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 2/2] drm/rockchip: Send events for same-fb flips Date: Mon, 16 Nov 2015 15:37:47 +0100 Message-ID: <5211128.CWIxWJvBWm@diego> References: <1447678222-6858-1-git-send-email-daniels@collabora.com> <1447678222-6858-2-git-send-email-daniels@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1447678222-6858-2-git-send-email-daniels-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Daniel Stone Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sjoerd Simons , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Am Montag, 16. November 2015, 12:50:22 schrieb Daniel Stone: > Rockchip previously treated a pageflip to the same framebuffer as a > no-op, discarding the event if one was requested. This breaks Weston, > which, when idle, sends a no-op vblank event to discover vblank > timings if the vblank query interface is not usable. > > Silently dropping events is also quite a hostile thing to do to > userspace in general. > > Signed-off-by: Daniel Stone > Cc: Sjoerd Simons > Cc: Heiko Stuebner on a rk3288_veyron_jerry Tested-by: Heiko Stuebner Everything up to GLES2 using the binary userspace driver still works