From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Weil Subject: Re: [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL Date: Sun, 18 Aug 2013 20:37:13 +0200 Message-ID: <52111459.2060809@weilnetz.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , "qemu-devel@nongnu.org" , Gleb Natapov , kvm To: "Liu, Jinsong" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org Am 18.08.2013 20:23, schrieb Liu, Jinsong: > From 1273f8b2e5464ec987facf9942fd3ccc0b69087e Mon Sep 17 00:00:00 2001 > From: Liu Jinsong > Date: Mon, 19 Aug 2013 09:33:30 +0800 > Subject: [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL > > This patch is to fix the bug https://bugs.launchpad.net/qemu-kvm/+bug/1207623 > > IA32_FEATURE_CONTROL is pointless if not expose VMX or SMX bits to > cpuid.1.ecx of vcpu. Current qemu-kvm will error return when kvm_put_msrs > or kvm_get_msrs. > > Signed-off-by: Liu Jinsong > --- > target-i386/kvm.c | 16 ++++++++++++++-- > 1 files changed, 14 insertions(+), 2 deletions(-) > Hello, please check your patch with scripts/checkpatch.pl before sending it to the list. For boolean operands, the boolean or (||) is better than the bitwise or (|). Regards, Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VB7r4-0002md-TL for qemu-devel@nongnu.org; Sun, 18 Aug 2013 14:37:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VB7qy-00054R-Uy for qemu-devel@nongnu.org; Sun, 18 Aug 2013 14:37:34 -0400 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:40148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VB7qy-000540-PB for qemu-devel@nongnu.org; Sun, 18 Aug 2013 14:37:28 -0400 Message-ID: <52111459.2060809@weilnetz.de> Date: Sun, 18 Aug 2013 20:37:13 +0200 From: Stefan Weil MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Liu, Jinsong" Cc: Marcelo Tosatti , "qemu-devel@nongnu.org" , Gleb Natapov , kvm Am 18.08.2013 20:23, schrieb Liu, Jinsong: > From 1273f8b2e5464ec987facf9942fd3ccc0b69087e Mon Sep 17 00:00:00 2001 > From: Liu Jinsong > Date: Mon, 19 Aug 2013 09:33:30 +0800 > Subject: [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL > > This patch is to fix the bug https://bugs.launchpad.net/qemu-kvm/+bug/1207623 > > IA32_FEATURE_CONTROL is pointless if not expose VMX or SMX bits to > cpuid.1.ecx of vcpu. Current qemu-kvm will error return when kvm_put_msrs > or kvm_get_msrs. > > Signed-off-by: Liu Jinsong > --- > target-i386/kvm.c | 16 ++++++++++++++-- > 1 files changed, 14 insertions(+), 2 deletions(-) > Hello, please check your patch with scripts/checkpatch.pl before sending it to the list. For boolean operands, the boolean or (||) is better than the bitwise or (|). Regards, Stefan