From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCHv2 02/17] drm/omap: cleanup fbdev init/free Date: Wed, 28 Feb 2018 23:18:27 +0200 Message-ID: <5211304.1fMlPktsyB@avalon> References: <1519817174-20714-1-git-send-email-tomi.valkeinen@ti.com> <1519817174-20714-3-git-send-email-tomi.valkeinen@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5CD66EB74 for ; Wed, 28 Feb 2018 21:17:38 +0000 (UTC) In-Reply-To: <1519817174-20714-3-git-send-email-tomi.valkeinen@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: Peter Ujfalusi , Jyri Sarha , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVG9taSwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gV2VkbmVzZGF5LCAyOCBGZWJy dWFyeSAyMDE4IDEzOjI1OjU5IEVFVCBUb21pIFZhbGtlaW5lbiB3cm90ZToKPiBvbWFwX2ZiZGV2 X2luaXQoKSBhbmQgb21hcF9mYmRldl9mcmVlKCkgdXNlIHByaXYtPmZiZGV2IGRpcmVjdGx5Lgo+ IEhvd2V2ZXIsIG9tYXBfZmJkZXZfaW5pdCgpIHJldHVybnMgdGhlIGZiZGV2LCBhbmQgb21hcF9k cnYuYyBhbHNvCj4gYXNzaWducyB0aGUgcmV0dXJuIHZhbHVlIHRvIHByaXYtPmZiZGV2LiBUaGlz IGlzIHNsaWdodGx5IGNvbmZ1c2luZy4KPiAKPiBDbGVhbiB0aGlzIHVwIGJ5IHJlbW92aW5nIHRo ZSBvbWFwX2ZiZGV2X2luaXQoKSByZXR1cm4gdmFsdWUsIGFzIHdlCj4gZG9uJ3QgY2FyZSB3aGV0 aGVyIGZiZGV2IGluaXQgc3VjY2VlZGVkIG9yIG5vdC4gQWxzbyBjaGFuZ2Ugb21hcF9kcnYuYwo+ IHRvIGNhbGwgb21hcF9mYmRldl9mcmVlKCkgYWx3YXlzLCBhbmQgb21hcF9mYmRldl9mcmVlKCkg ZG9lcyB0aGUgY2hlY2sKPiBpZiBmYmRldiB3YXMgaW5pdGlhbGl6ZWQuCj4gCj4gV2hpbGUgYXQg aXQsIHJlbmFtZSBvbWFwX2ZiZGV2X2ZyZWUoKSB0byBvbWFwX2ZiZGV2X2ZpbmkoKSB0byBiZXR0 ZXIKPiBtYXRjaCB0aGUgImluaXQiIGNvdW50ZXJwYXJ0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFRv bWkgVmFsa2VpbmVuIDx0b21pLnZhbGtlaW5lbkB0aS5jb20+CgpSZXZpZXdlZC1ieTogTGF1cmVu dCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoKPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9kcnYuYyAgIHwgIDkgKysrKy0tLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZmJkZXYuYyB8IDE4ICsrKysrKysrLS0tLS0tLS0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2ZiZGV2LmggfCAgOSArKysrLS0tLS0K PiAgMyBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9kcnYuYwo+IGIvZHJp dmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9kcnYuYyBpbmRleCA2NWE1NjdkY2YzYWIuLjRmNDhi OTA4YmRjNgo+IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZHJ2 LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5jCj4gQEAgLTU3MCw3 ICs1NzAsNyBAQCBzdGF0aWMgaW50IG9tYXBkcm1faW5pdChzdHJ1Y3Qgb21hcF9kcm1fcHJpdmF0 ZSAqcHJpdiwKPiBzdHJ1Y3QgZGV2aWNlICpkZXYpIGZvciAoaSA9IDA7IGkgPCBwcml2LT5udW1f Y3J0Y3M7IGkrKykKPiAgCQlkcm1fY3J0Y192Ymxhbmtfb2ZmKHByaXYtPmNydGNzW2ldKTsKPiAK PiAtCXByaXYtPmZiZGV2ID0gb21hcF9mYmRldl9pbml0KGRkZXYpOwo+ICsJb21hcF9mYmRldl9p bml0KGRkZXYpOwo+IAo+ICAJZHJtX2ttc19oZWxwZXJfcG9sbF9pbml0KGRkZXYpOwo+ICAJb21h cF9tb2Rlc2V0X2VuYWJsZV9leHRlcm5hbF9ocGQoKTsKPiBAQCAtNTg4LDggKzU4OCw4IEBAIHN0 YXRpYyBpbnQgb21hcGRybV9pbml0KHN0cnVjdCBvbWFwX2RybV9wcml2YXRlICpwcml2LAo+IHN0 cnVjdCBkZXZpY2UgKmRldikgZXJyX2NsZWFudXBfaGVscGVyczoKPiAgCW9tYXBfbW9kZXNldF9k aXNhYmxlX2V4dGVybmFsX2hwZCgpOwo+ICAJZHJtX2ttc19oZWxwZXJfcG9sbF9maW5pKGRkZXYp Owo+IC0JaWYgKHByaXYtPmZiZGV2KQo+IC0JCW9tYXBfZmJkZXZfZnJlZShkZGV2KTsKPiArCj4g KwlvbWFwX2ZiZGV2X2ZpbmkoZGRldik7Cj4gIGVycl9jbGVhbnVwX21vZGVzZXQ6Cj4gIAlkcm1f bW9kZV9jb25maWdfY2xlYW51cChkZGV2KTsKPiAgCW9tYXBfZHJtX2lycV91bmluc3RhbGwoZGRl dik7Cj4gQEAgLTYxNSw4ICs2MTUsNyBAQCBzdGF0aWMgdm9pZCBvbWFwZHJtX2NsZWFudXAoc3Ry dWN0IG9tYXBfZHJtX3ByaXZhdGUKPiAqcHJpdikgb21hcF9tb2Rlc2V0X2Rpc2FibGVfZXh0ZXJu YWxfaHBkKCk7Cj4gIAlkcm1fa21zX2hlbHBlcl9wb2xsX2ZpbmkoZGRldik7Cj4gCj4gLQlpZiAo cHJpdi0+ZmJkZXYpCj4gLQkJb21hcF9mYmRldl9mcmVlKGRkZXYpOwo+ICsJb21hcF9mYmRldl9m aW5pKGRkZXYpOwo+IAo+ICAJZHJtX2F0b21pY19oZWxwZXJfc2h1dGRvd24oZGRldik7Cj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZmJkZXYuYwo+IGIvZHJp dmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9mYmRldi5jIGluZGV4IDYzMmViY2YyMTY1Zi4uYmU5 NDQ4MDMyNmQ3Cj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9m YmRldi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9mYmRldi5jCj4gQEAg LTI0Miw3ICsyNDIsNyBAQCBzdGF0aWMgc3RydWN0IGRybV9mYl9oZWxwZXIgKmdldF9mYihzdHJ1 Y3QgZmJfaW5mbyAqZmJpKQo+IH0KPiAKPiAgLyogaW5pdGlhbGl6ZSBmYmRldiBoZWxwZXIgKi8K PiAtc3RydWN0IGRybV9mYl9oZWxwZXIgKm9tYXBfZmJkZXZfaW5pdChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2KQo+ICt2b2lkIG9tYXBfZmJkZXZfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ ICB7Cj4gIAlzdHJ1Y3Qgb21hcF9kcm1fcHJpdmF0ZSAqcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7 Cj4gIAlzdHJ1Y3Qgb21hcF9mYmRldiAqZmJkZXYgPSBOVUxMOwo+IEBAIC0yNjAsMTAgKzI2MCw4 IEBAIHN0cnVjdCBkcm1fZmJfaGVscGVyICpvbWFwX2ZiZGV2X2luaXQoc3RydWN0IGRybV9kZXZp Y2UKPiAqZGV2KSBkcm1fZmJfaGVscGVyX3ByZXBhcmUoZGV2LCBoZWxwZXIsICZvbWFwX2ZiX2hl bHBlcl9mdW5jcyk7Cj4gCj4gIAlyZXQgPSBkcm1fZmJfaGVscGVyX2luaXQoZGV2LCBoZWxwZXIs IHByaXYtPm51bV9jb25uZWN0b3JzKTsKPiAtCWlmIChyZXQpIHsKPiAtCQlkZXZfZXJyKGRldi0+ ZGV2LCAiY291bGQgbm90IGluaXQgZmJkZXY6IHJldD0lZFxuIiwgcmV0KTsKPiArCWlmIChyZXQp Cj4gIAkJZ290byBmYWlsOwo+IC0JfQo+IAo+ICAJcmV0ID0gZHJtX2ZiX2hlbHBlcl9zaW5nbGVf YWRkX2FsbF9jb25uZWN0b3JzKGhlbHBlcik7Cj4gIAlpZiAocmV0KQo+IEBAIC0yNzUsNyArMjcz LDcgQEAgc3RydWN0IGRybV9mYl9oZWxwZXIgKm9tYXBfZmJkZXZfaW5pdChzdHJ1Y3QgZHJtX2Rl dmljZQo+ICpkZXYpCj4gCj4gIAlwcml2LT5mYmRldiA9IGhlbHBlcjsKPiAKPiAtCXJldHVybiBo ZWxwZXI7Cj4gKwlyZXR1cm47Cj4gCj4gIGZpbmk6Cj4gIAlkcm1fZmJfaGVscGVyX2ZpbmkoaGVs cGVyKTsKPiBAQCAtMjgzLDEyICsyODEsOSBAQCBzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqb21hcF9m YmRldl9pbml0KHN0cnVjdCBkcm1fZGV2aWNlCj4gKmRldikga2ZyZWUoZmJkZXYpOwo+IAo+ICAJ ZGV2X3dhcm4oZGV2LT5kZXYsICJvbWFwX2ZiZGV2X2luaXQgZmFpbGVkXG4iKTsKPiAtCS8qIHdl bGwsIGxpbXAgYWxvbmcgd2l0aG91dCBhbiBmYmRldi4uIG1heWJlIFgxMSB3aWxsIHdvcms/ICov Cj4gLQo+IC0JcmV0dXJuIE5VTEw7Cj4gIH0KPiAKPiAtdm9pZCBvbWFwX2ZiZGV2X2ZyZWUoc3Ry dWN0IGRybV9kZXZpY2UgKmRldikKPiArdm9pZCBvbWFwX2ZiZGV2X2Zpbmkoc3RydWN0IGRybV9k ZXZpY2UgKmRldikKPiAgewo+ICAJc3RydWN0IG9tYXBfZHJtX3ByaXZhdGUgKnByaXYgPSBkZXYt PmRldl9wcml2YXRlOwo+ICAJc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciA9IHByaXYtPmZi ZGV2Owo+IEBAIC0yOTYsMTEgKzI5MSwxNCBAQCB2b2lkIG9tYXBfZmJkZXZfZnJlZShzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2KQo+IAo+ICAJREJHKCk7Cj4gCj4gKwlpZiAoIWhlbHBlcikKPiArCQly ZXR1cm47Cj4gKwo+ICAJZHJtX2ZiX2hlbHBlcl91bnJlZ2lzdGVyX2ZiaShoZWxwZXIpOwo+IAo+ ICAJZHJtX2ZiX2hlbHBlcl9maW5pKGhlbHBlcik7Cj4gCj4gLQlmYmRldiA9IHRvX29tYXBfZmJk ZXYocHJpdi0+ZmJkZXYpOwo+ICsJZmJkZXYgPSB0b19vbWFwX2ZiZGV2KGhlbHBlcik7Cj4gCj4g IAkvKiB1bnBpbiB0aGUgR0VNIG9iamVjdCBwaW5uZWQgaW4gb21hcF9mYmRldl9jcmVhdGUoKSAq Lwo+ICAJaWYgKGZiZGV2LT5ibykKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL29tYXBk cm0vb21hcF9mYmRldi5oCj4gYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2ZiZGV2Lmgg aW5kZXggMWY1YmEwOTk2YTFhLi43ZGZkODQzZjczZjEKPiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vb21hcGRybS9vbWFwX2ZiZGV2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vb21h cGRybS9vbWFwX2ZiZGV2LmgKPiBAQCAtMjQsMTQgKzI0LDEzIEBAIHN0cnVjdCBkcm1fZGV2aWNl Owo+ICBzdHJ1Y3QgZHJtX2ZiX2hlbHBlcjsKPiAKPiAgI2lmZGVmIENPTkZJR19EUk1fRkJERVZf RU1VTEFUSU9OCj4gLXN0cnVjdCBkcm1fZmJfaGVscGVyICpvbWFwX2ZiZGV2X2luaXQoc3RydWN0 IGRybV9kZXZpY2UgKmRldik7Cj4gLXZvaWQgb21hcF9mYmRldl9mcmVlKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpOwo+ICt2b2lkIG9tYXBfZmJkZXZfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KTsKPiArdm9pZCBvbWFwX2ZiZGV2X2Zpbmkoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gICNl bHNlCj4gLXN0YXRpYyBpbmxpbmUgc3RydWN0IGRybV9mYl9oZWxwZXIgKm9tYXBfZmJkZXZfaW5p dChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICtzdGF0aWMgaW5saW5lIHZvaWQgb21hcF9mYmRl dl9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIHsKPiAtCXJldHVybiBOVUxMOwo+ICB9 Cj4gLXN0YXRpYyBpbmxpbmUgdm9pZCBvbWFwX2ZiZGV2X2ZyZWUoc3RydWN0IGRybV9kZXZpY2Ug KmRldikKPiArc3RhdGljIGlubGluZSB2b2lkIG9tYXBfZmJkZXZfZmluaShzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2KQo+ICB7Cj4gIH0KPiAgI2VuZGlmCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGlu Y2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=