All of lore.kernel.org
 help / color / mirror / Atom feed
From: Donghwa Lee <dh09.lee@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] Origen: Set FIMD as the default display path
Date: Mon, 19 Aug 2013 10:52:31 +0900	[thread overview]
Message-ID: <52117A5F.3020104@samsung.com> (raw)
In-Reply-To: <CAEC9eQPtS8ch2M0BhG+mhbnhEX3g-qYRZBZtFGtdaCdbZWSLiw@mail.gmail.com>

On Fri, Aug 16, 2013 at 16:31, Ajay kumar wrote:
> On Thu, Aug 15, 2013 at 6:53 PM, Tushar Behera <tushar.behera at linaro.org <mailto:tushar.behera@linaro.org>> wrote:
>
>     On EXYNOS4210, there are three paths for display data to be processed,
>     namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
>     is used.
>
>     Signed-off-by: Tushar Behera <tushar.behera at linaro.org <mailto:tushar.behera@linaro.org>>
>     ---
>     Changes for V2:
>     * Updated review comments from Ajay Kumar, reusing the code from
>     arch/arm/cpu/armv7/exynos/system.c.
>
>      board/samsung/origen/origen.c |    3 +++
>      1 file changed, 3 insertions(+)
>
>     diff --git a/board/samsung/origen/origen.c b/board/samsung/origen/origen.c
>     index 15f77ca..bb16699 100644
>     --- a/board/samsung/origen/origen.c
>     +++ b/board/samsung/origen/origen.c
>     @@ -22,6 +22,9 @@ int board_init(void)
>             gpio2 = (struct exynos4_gpio_part2 *) EXYNOS4_GPIO_PART2_BASE;
>
>             gd->bd->bi_boot_params = (PHYS_SDRAM_1 + 0x100UL);
>     +
>     +       set_system_display_ctrl();
>     +
>
> Ok. You are trying to get the display up in the kernel,
> without enabling the display in u-boot.
> And, thats why you are making an explicit call here?
>
Previously, Ajay kumar said set_system_display_ctrl() function is already called by
lcd_ctrl_init() of exynos_fb.c.
If you need to use FIMD path, you'd better use the existing one.
>
>             return 0;
>      }
>
>     --
>     1.7.9.5
>
>

  reply	other threads:[~2013-08-19  1:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07 10:56 [U-Boot] [PATCH] Origen: Set FIMD as the default display path Tushar Behera
2013-06-07 10:56 ` Tushar Behera
2013-08-06  2:59   ` Minkyu Kang
2013-08-06  3:07     ` Tushar Behera
2013-08-06  8:51       ` Ajay kumar
2013-08-06 10:40         ` Tushar Behera
2013-08-15 10:09           ` Tushar Behera
2013-08-15  9:53 ` [U-Boot] [PATCH V2] " Tushar Behera
2013-08-16  7:31   ` Ajay kumar
2013-08-19  1:52     ` Donghwa Lee [this message]
2013-08-19  3:06       ` Tushar Behera
2013-08-19  4:31         ` Donghwa Lee
2013-08-19  6:00           ` Tushar Behera
2013-08-28 11:47             ` Tushar Behera
2013-08-30  5:07               ` Minkyu Kang
2013-08-30  6:34                 ` Tushar Behera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52117A5F.3020104@samsung.com \
    --to=dh09.lee@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.